Chore: Avoid shell in Docker health check #444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I fail to understand the benefit of this approach - are you able to explain it to me please? |
|
As it stands, without this change, the healthcheck runs a shell in the container, which runs |
|
I think HEALTHCHECK was moved to an optional extension and not really part of the standard OCI image spec .. not that it hurts anything having it but it's a very Docker specific thing now. |
|
Oh right, I understand. Thank you, accepted 👍 |
axllent
pushed a commit
that referenced
this pull request
Mar 1, 2025
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Mar 6, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [axllent/mailpit](https://github.com/axllent/mailpit) | minor | `v1.22.3` -> `v1.23.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>axllent/mailpit (axllent/mailpit)</summary> ### [`v1.23.0`](https://github.com/axllent/mailpit/blob/HEAD/CHANGELOG.md#v1230) [Compare Source](axllent/mailpit@v1.22.3...v1.23.0) ##### Feature - Add configuration to disable SQLite WAL mode for NFS compatibility - Add configuration to explicitly disable HTTP compression in web UI/API ([#​448](axllent/mailpit#448)) - Add configuration to set message compression level in db (0-3) ([#​447](axllent/mailpit#447) & [#​448](axllent/mailpit#448)) ##### Chore - Update node dependencies - Update Go dependencies - Minor speed & memory improvements when storing messages - Optimize ZSTD encoder for fastest compression of messages ([#​447](axllent/mailpit#447)) - Handle BLOB storage for default database differently to rqlite to reduce memory overhead ([#​447](axllent/mailpit#447)) - Avoid shell in Docker health check ([#​444](axllent/mailpit#444)) ##### Fix - Display the correct STARTTLS or TLS runtime option on startup ([#​446](axllent/mailpit#446)) ##### Testing - Add tests for message compression levels </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xODIuNCIsInVwZGF0ZWRJblZlciI6IjM5LjE4Mi40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hardly significant, but... why not :)
https://docs.docker.com/reference/dockerfile/#healthcheck
Before (
docker image inspect axllent/mailpit | jq ".[0].Config.Healthcheck.Test"):After: