Fix some warnings

Author: hughcars

palace/drivers/drivensolver.cpp

@@ -41,7 +41,7 @@ DrivenSolver::Solve(const std::vector<std::unique_ptr<Mesh>> &mesh) const
   auto omega = iodata.solver.driven.sample_f;
   if (iodata.solver.driven.rst > 0)
   {
-    MFEM_VERIFY(iodata.solver.driven.rst <= omega.size(),
+    MFEM_VERIFY(iodata.solver.driven.rst <= static_cast<int>(omega.size()),
                 "\"Restart\": (" << iodata.solver.driven.rst
                                  << ") is greater than the number of samples ("
                                  << omega.size() << ")!");

palace/drivers/electrostaticsolver.cpp

@@ -163,7 +163,7 @@ void ElectrostaticSolver::PostprocessTerminals(
       output.table["i"] << idx2;
 
       auto &col = output.table[format("i2{}", idx2)];
-      for (int i = 0; i < terminal_sources.size(); i++)
+      for (std::size_t i = 0; i < terminal_sources.size(); i++)
       {
         col << mat(i, j) * scale;
       }

palace/drivers/magnetostaticsolver.cpp

@@ -168,7 +168,7 @@ void MagnetostaticSolver::PostprocessTerminals(
       output.table["i"] << idx2;
 
       auto &col = output.table[format("i2{}", idx2)];
-      for (int i = 0; i < surf_j_op.Size(); i++)
+      for (std::size_t i = 0; i < surf_j_op.Size(); i++)
       {
         col << mat(i, j) * scale;
       }

palace/models/materialoperator.hpp

@@ -39,15 +39,15 @@ class MaterialOperator
   void SetUpMaterialProperties(const IoData &iodata, const mfem::ParMesh &mesh);
   void SetUpFloquetWaveVector(const IoData &iodata, const mfem::ParMesh &mesh);
 
-  const auto AttrToMat(int attr) const
+  auto AttrToMat(int attr) const
   {
     const auto &loc_attr = mesh.GetCeedAttributes();
     MFEM_ASSERT(loc_attr.find(attr) != loc_attr.end(),
                 "Missing libCEED domain attribute for attribute " << attr << "!");
     return attr_mat[loc_attr.at(attr) - 1];
   }
 
-  const auto Wrap(const mfem::DenseTensor &data, int attr) const
+  auto Wrap(const mfem::DenseTensor &data, int attr) const
   {
     const int k = AttrToMat(attr);
     return mfem::DenseMatrix(const_cast<double *>(data.GetData(k)), data.SizeI(),
@@ -59,17 +59,17 @@ class MaterialOperator
 
   int SpaceDimension() const { return mat_muinv.SizeI(); }
 
-  const auto GetInvPermeability(int attr) const { return Wrap(mat_muinv, attr); }
-  const auto GetPermittivityReal(int attr) const { return Wrap(mat_epsilon, attr); }
-  const auto GetPermittivityImag(int attr) const { return Wrap(mat_epsilon_imag, attr); }
-  const auto GetPermittivityAbs(int attr) const { return Wrap(mat_epsilon_abs, attr); }
-  const auto GetInvImpedance(int attr) const { return Wrap(mat_invz0, attr); }
-  const auto GetLightSpeed(int attr) const { return Wrap(mat_c0, attr); }
-  const auto GetConductivity(int attr) const { return Wrap(mat_sigma, attr); }
-  const auto GetInvLondonDepth(int attr) const { return Wrap(mat_invLondon, attr); }
-  const auto GetFloquetCurl(int attr) const { return Wrap(mat_muinvkx, attr); }
-  const auto GetFloquetMass(int attr) const { return Wrap(mat_kxTmuinvkx, attr); }
-  const auto GetFloquetCross(int attr) const { return Wrap(mat_kx, attr); }
+  auto GetInvPermeability(int attr) const { return Wrap(mat_muinv, attr); }
+  auto GetPermittivityReal(int attr) const { return Wrap(mat_epsilon, attr); }
+  auto GetPermittivityImag(int attr) const { return Wrap(mat_epsilon_imag, attr); }
+  auto GetPermittivityAbs(int attr) const { return Wrap(mat_epsilon_abs, attr); }
+  auto GetInvImpedance(int attr) const { return Wrap(mat_invz0, attr); }
+  auto GetLightSpeed(int attr) const { return Wrap(mat_c0, attr); }
+  auto GetConductivity(int attr) const { return Wrap(mat_sigma, attr); }
+  auto GetInvLondonDepth(int attr) const { return Wrap(mat_invLondon, attr); }
+  auto GetFloquetCurl(int attr) const { return Wrap(mat_muinvkx, attr); }
+  auto GetFloquetMass(int attr) const { return Wrap(mat_kxTmuinvkx, attr); }
+  auto GetFloquetCross(int attr) const { return Wrap(mat_kx, attr); }
 
   auto GetLightSpeedMin(int attr) const { return mat_c0_min[AttrToMat(attr)]; }
   auto GetLightSpeedMax(int attr) const { return mat_c0_max[AttrToMat(attr)]; }

palace/utils/geodata.hpp

@@ -187,7 +187,7 @@ inline double GetDistanceFromPoint(const mfem::ParMesh &mesh, int attr, bool bdr
   mfem::Array<int> marker(bdr ? mesh.bdr_attributes.Max() : mesh.attributes.Max());
   marker = 0;
   marker[attr - 1] = 1;
-  return GetDistanceFromPoint(mesh, marker, bdr, dir);
+  return GetDistanceFromPoint(mesh, marker, bdr, dir, max);
 }
 
 // Helper function to compute the average surface normal for all elements with the given