Skip to content

Commit a0fd766

Browse files
authored
Redundant labels from events controller (#102)
1 parent 885371b commit a0fd766

File tree

2 files changed

+0
-4
lines changed

2 files changed

+0
-4
lines changed

events/controller.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,6 @@ func (c *Controller[T]) Reconcile(ctx context.Context, event *v1.Event) (reconci
5454
// since we don't duplicate metrics on controller restart or lease handover
5555
if c.startTime.Before(event.LastTimestamp.Time) {
5656
c.EventCount.Inc(map[string]string{
57-
pmetrics.LabelGroup: c.gvk.Group,
58-
pmetrics.LabelKind: event.InvolvedObject.Kind,
5957
pmetrics.LabelType: event.Type,
6058
pmetrics.LabelReason: event.Reason,
6159
})

events/metrics.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@ func eventTotalMetric(objectName string) pmetrics.CounterMetric {
1616
Help: "The total of events of a given type for an object.",
1717
},
1818
[]string{
19-
pmetrics.LabelGroup,
20-
pmetrics.LabelKind,
2119
pmetrics.LabelType,
2220
pmetrics.LabelReason,
2321
},

0 commit comments

Comments
 (0)