Fix a bunch of places we forget to aws_raise_error() (#111)

Author: graebm

.github/workflows/ci.yml

@@ -7,7 +7,7 @@ on:
 
 
 env:
-  BUILDER_VERSION: v0.9.43
+  BUILDER_VERSION: v0.9.55
   BUILDER_SOURCE: releases
   BUILDER_HOST: https://d19elf31gohf1l.cloudfront.net
   PACKAGE_NAME: aws-c-event-stream

source/event_stream_channel_handler.c

@@ -447,7 +447,7 @@ static int s_process_write_message(
     (void)slot;
     (void)message;
     AWS_FATAL_ASSERT(!"The event-stream-channel-handler is not designed to be a mid-channel handler.");
-    return AWS_OP_ERR;
+    return aws_raise_error(AWS_ERROR_UNIMPLEMENTED);
 }
 
 static int s_increment_read_window(struct aws_channel_handler *handler, struct aws_channel_slot *slot, size_t size) {

source/event_stream_rpc_client.c

@@ -499,16 +499,6 @@ static int s_send_protocol_message(
 
     struct event_stream_connection_send_message_args *args =
         aws_mem_calloc(connection->allocator, 1, sizeof(struct event_stream_connection_send_message_args));
-
-    if (!message_args) {
-        AWS_LOGF_ERROR(
-            AWS_LS_EVENT_STREAM_RPC_CLIENT,
-            "id=%p: failed to allocate callback arguments %s.",
-            (void *)connection,
-            aws_error_debug_str(aws_last_error()));
-        return AWS_OP_ERR;
-    }
-
     args->allocator = connection->allocator;
     args->user_data = user_data;
     args->message_type = message_args->message_type;

source/event_stream_rpc_server.c

@@ -570,16 +570,6 @@ static int s_send_protocol_message(
 
     struct event_stream_connection_send_message_args *args =
         aws_mem_calloc(connection->allocator, 1, sizeof(struct event_stream_connection_send_message_args));
-
-    if (!message_args) {
-        AWS_LOGF_ERROR(
-            AWS_LS_EVENT_STREAM_RPC_SERVER,
-            "id=%p: allocation of callback args failed with error %s",
-            (void *)connection,
-            aws_error_debug_str(aws_last_error()));
-        return AWS_OP_ERR;
-    }
-
     args->allocator = connection->allocator;
     args->user_data = user_data;
     args->message_type = message_args->message_type;