Skip to content

Commit 052077f

Browse files
authored
Bump PIC version and small stack size test (#461)
* Bump PIC and small stack size test * Bump configure-aws-creds to v4 * Move AWS credentials to after build * Add permissions * Cd build * Use preinstalled toolchain * Check for seg fault message * Check exit code
1 parent 63d63e5 commit 052077f

File tree

2 files changed

+36
-1
lines changed

2 files changed

+36
-1
lines changed

.github/workflows/ci.yml

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -487,3 +487,38 @@ jobs:
487487
mkdir build && cd build
488488
cmake .. -DBUILD_STATIC=ON
489489
make
490+
491+
linux-thread-size-check:
492+
runs-on: ubuntu-latest
493+
permissions:
494+
id-token: write
495+
contents: read
496+
steps:
497+
- name: Clone repository
498+
uses: actions/checkout@v3
499+
- name: Configure AWS Credentials
500+
uses: aws-actions/configure-aws-credentials@v4
501+
with:
502+
role-to-assume: ${{ secrets.AWS_ROLE_TO_ASSUME }}
503+
role-session-name: ${{ secrets.AWS_ROLE_SESSION_NAME }}
504+
aws-region: ${{ secrets.AWS_REGION }}
505+
role-duration-seconds: 10800
506+
- name: Build Repository
507+
run: |
508+
mkdir build && cd build
509+
cmake .. -DBUILD_TEST=TRUE -DKVS_DEFAULT_STACK_SIZE=65536
510+
make -j$(nproc)
511+
- name: Run tests with expected failure
512+
run: |
513+
set +e
514+
cd build
515+
./tst/producer_test --gtest_filter="ProducerClientBasicTest.*"
516+
TEST_EXIT_CODE=$?
517+
518+
# 128 (abnormal exit) + 11 (segmentation fault) = 139
519+
if [ $TEST_EXIT_CODE -ne 139 ]; then
520+
echo "Unexpected exit code: $TEST_EXIT_CODE"
521+
exit 1
522+
fi
523+
echo "Test exited as expected with code $TEST_EXIT_CODE."
524+
shell: bash

CMake/Dependencies/libkvspic-CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ include(ExternalProject)
77
# clone repo only
88
ExternalProject_Add(libkvspic-download
99
GIT_REPOSITORY https://github.com/awslabs/amazon-kinesis-video-streams-pic.git
10-
GIT_TAG v1.1.0
10+
GIT_TAG v1.2.0
1111
SOURCE_DIR "${CMAKE_CURRENT_BINARY_DIR}/kvspic-src"
1212
BINARY_DIR "${CMAKE_CURRENT_BINARY_DIR}/kvspic-build"
1313
CMAKE_ARGS

0 commit comments

Comments
 (0)