Skip to content

Commit 308d9ce

Browse files
authored
chore: add missing partition to edge config support (#3605)
1 parent c8e7cf8 commit 308d9ce

File tree

2 files changed

+5
-11
lines changed

2 files changed

+5
-11
lines changed

samtranslator/region_configuration.py

+4-2
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,10 @@ def is_apigw_edge_configuration_supported(cls) -> bool:
1717
1818
:return: True, if API Gateway does not support Edge configuration
1919
"""
20-
21-
return ArnGenerator.get_partition_name() not in ["aws-us-gov", "aws-iso", "aws-iso-b", "aws-cn", "aws-iso-e"]
20+
partition = ArnGenerator.get_partition_name()
21+
if partition.startswith("aws-iso") or partition in ["aws-us-gov", "aws-cn"]:
22+
return False
23+
return True
2224

2325
@classmethod
2426
def is_service_supported(cls, service, region=None): # type: ignore[no-untyped-def]

tests/unit/test_region_configuration.py

+1-9
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,7 @@ def test_when_apigw_edge_configuration_supported(self, partition):
2020

2121
self.assertTrue(RegionConfiguration.is_apigw_edge_configuration_supported())
2222

23-
@parameterized.expand(
24-
[
25-
["aws-cn"],
26-
["aws-us-gov"],
27-
["aws-iso"],
28-
["aws-iso-b"],
29-
["aws-iso-e"],
30-
]
31-
)
23+
@parameterized.expand([["aws-cn"], ["aws-us-gov"], ["aws-iso"], ["aws-iso-b"], ["aws-iso-e"], ["aws-iso-f"]])
3224
def test_when_apigw_edge_configuration_is_not_supported(self, partition):
3325
with patch(
3426
"samtranslator.translator.arn_generator.ArnGenerator.get_partition_name"

0 commit comments

Comments
 (0)