Skip to content

Update cppcheck #5239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
goatgoose opened this issue Apr 1, 2025 · 1 comment
Open

Update cppcheck #5239

goatgoose opened this issue Apr 1, 2025 · 1 comment
Labels
good first issue priority/high Rank 2 size/medium

Comments

@goatgoose
Copy link
Contributor

Problem:

The cppcheck build started failing, and was fixed in #5238. The workaround to get it building is not great though, and was added just to get the CI passing again. Ideally we would bump the cppcheck version to the latest release instead. However, this is a bigger change since it will require fixing many new suggestions the new version will have.

Solution:

Update cppcheck and fix any new suggestions that are raised.
@goatgoose goatgoose mentioned this issue Apr 1, 2025
Merged
@goatgoose
Copy link
Contributor Author

We should check to see if there's a prebuilt github action for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue priority/high Rank 2 size/medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@goatgoose