Consider Changing -fPIC to PRIVATE in CMakeLists.txt

[souvik1997]

Hi,

I noticed that in the CMake configuration, the -fPIC compile option is added as a PUBLIC option:

s2n-tls/CMakeLists.txt

Line 192 in 785ed14

target_compile_options(${PROJECT_NAME} PUBLIC -fPIC)

Would it be possible to change this to PRIVATE? Making it PUBLIC propagates -fPIC to all targets linking s2n, which might be unnecessary or even problematic for some consumers of the library.

[souvik1997]

#5189

[boquan-fang]

Hi Souvik,

Thanks for cutting this issue to us. I have seen your PR: #5189.

Reviewers are already assigned for this PR. Please continue to work with @camshaft and @lrstewart to resolve this issue.

Thanks