Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): Refactor GHA rust toolchain install #5172

Open
dougch opened this issue Mar 7, 2025 · 0 comments
Open

chore(ci): Refactor GHA rust toolchain install #5172

dougch opened this issue Mar 7, 2025 · 0 comments
Labels
priority/low Rank 4 size/small

Comments

@dougch
Copy link
Contributor

dougch commented Mar 7, 2025 •
edited by boquan-fang
Loading

Problem:

The rustup behavior change was difficult to centrally update all the toolchain installs. Doing it in the generate.sh script was a short term mitigation.

Solution:

  1. Explicitly provide the version in the toolchain install, e.g. how quic does it
  2. Move the version to a centrally update-able variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority/low Rank 4 size/small
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dougch @boquan-fang