Skip to content

s2n-tls needs a chroot test #4360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maddeleine opened this issue Jan 11, 2024 · 2 comments
Open

s2n-tls needs a chroot test #4360

maddeleine opened this issue Jan 11, 2024 · 2 comments

Comments

@maddeleine
Copy link
Contributor

maddeleine commented Jan 11, 2024

Problem:

s2n-tls was built with the idea of being functional after a chroot call. We don't have any tests that assert that we can still do a handshake after a call to chroot. Presumably the fear is that after the call we may not be able to access our entropy file descriptor to pull random values.

Solution:

Add a test that calls chroot() after(before?) the s2n-library initialization and then performs a negotiation.

@brandonpike
Copy link

I would suggest a broader 'sandboxing' test (maybe out of scope of this issue). Isolation strategies like chroot and seccomp filtering might rely on s2n-tls fully initializing before-hand to avoid unwanted inits later for various reasons.

I recognize seccomp filtering is a hard one to test, as consumers will have varying syscall allowlists.

@goatgoose
Copy link
Contributor

Adding a seccomp test is being tracked in #4766

@goatgoose goatgoose added priority/medium Rank 3 and removed priority/high Rank 2 labels Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants