Skip to content

Ensure we're testing the correct state machine #3756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maddeleine opened this issue Jan 12, 2023 · 0 comments
Open

Ensure we're testing the correct state machine #3756

maddeleine opened this issue Jan 12, 2023 · 0 comments

Comments

@maddeleine
Copy link
Contributor

Security issue notifications

If you discover a potential security issue in s2n we ask that you notify
AWS Security via our vulnerability reporting page. Please do not create a public github issue.

Problem:

When the PR #3747 is merged it will change how the state machine is set. Instead of relying on the conn->actual_protocol_version, now we're relying on a new variable, conn->handshake.state_machine. We have written a lot of tests that set the actual_protocol_version and now the worry is that we might make an assumption that we're testing the TLS13 state machine when we're not.

Solution:

Everywhere in the tests that we set the actual_protocol_version, we should also call s2n_conn_choose_state_machine().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants