Skip to content

All Makefiles Should also Work with Cmake #3152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maddeleine opened this issue Dec 13, 2021 · 0 comments
Open

All Makefiles Should also Work with Cmake #3152

maddeleine opened this issue Dec 13, 2021 · 0 comments
Labels

Comments

@maddeleine
Copy link
Contributor

Security issue notifications

If you discover a potential security issue in s2n we ask that you notify
AWS Security via our vulnerability reporting page. Please do not create a public github issue.

Problem:

s2n is taking steps to move to building using cmake. Some of our Makefiles have no cmake counterpart and it needs to be added.

Solution:

Add cmake capabilities to any existing makefile. Off the top of my head I know there is one makefile in our integv2 folder that has no cmake capabilities. We should either convert this makefile to a build script (b/c the makefile never actually calls 'make') or add cmake capabilities to this folder.

  • Does this change what S2N sends over the wire? No
  • Does this change any public APIs? No
  • Which versions of TLS will this impact?
    N/A

Requirements / Acceptance Criteria:

All existing makefiles have a cmake counterpart OR all makefiles have been replaced by cmake 😈.

  • RFC links: N/A
  • Related Issues: N/A
  • Will the Usage Guide or other documentation need to be updated?
  • Testing: How will this change be tested? Call out new integration tests, functional tests, or particularly interesting/important unit tests.
    • Will this change trigger SAW changes? Changes to the state machine, the s2n_handshake_io code that controls state transitions, the DRBG, or the corking/uncorking logic could trigger SAW failures.
    • Should this change be fuzz tested? Will it handle untrusted input? Create a separate issue to track the fuzzing work.

Out of scope:

Is there anything the solution will intentionally NOT address?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants