Skip to content

Update API when we add groups other than EC to TLS1.3 #2924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maddeleine opened this issue Jun 23, 2021 · 0 comments
Open

Update API when we add groups other than EC to TLS1.3 #2924

maddeleine opened this issue Jun 23, 2021 · 0 comments
Labels

Comments

@maddeleine
Copy link
Contributor

maddeleine commented Jun 23, 2021

Security issue notifications

If you discover a potential security issue in s2n we ask that you notify
AWS Security via our vulnerability reporting page. Please do not create a public github issue.

Problem:

Currently, the PR #2908 relies on the fact that we only do ECC in TLS1.3. If we ever add more than ECC to TLS1.3, the function s2n_connection_get_curve will no longer work.

Solution:

When we add a new group to s2n-tls, we should update the function s2n_connection_get_curve as well to make sure it is still accurate.

  • Does this change what S2N sends over the wire? no
  • Does this change any public APIs? Eh, it adds functionality to a current API
  • Which versions of TLS will this impact?
    versions TLS13 and up

Requirements / Acceptance Criteria:

s2n_connection_get_curve is updated when a new group is added.

  • RFC links: N/A
  • Related Issues: N/A
  • Will the Usage Guide or other documentation need to be updated? Nope
  • Testing: Unit tests are fine
    • Will this change trigger SAW changes? N/A
    • Should this change be fuzz tested? N/A

Out of scope:

N/A

@maddeleine maddeleine changed the title Update s2n_connection_get_curve if we ever add groups other than EC Update s2n_connection_get_curve when we add groups other than EC to TLS1.3 Jun 23, 2021
@maddeleine maddeleine changed the title Update s2n_connection_get_curve when we add groups other than EC to TLS1.3 Update API when we add groups other than EC to TLS1.3 Jun 23, 2021
@dougch dougch added the s2n-core team label Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants