Skip to content

Improvements to s2nc/s2nd/echo #2838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
4 tasks
maddeleine opened this issue May 17, 2021 · 0 comments
Open
4 tasks

Improvements to s2nc/s2nd/echo #2838

maddeleine opened this issue May 17, 2021 · 0 comments
Labels

Comments

@maddeleine
Copy link
Contributor

Security issue notifications

If you discover a potential security issue in s2n we ask that you notify
AWS Security via our vulnerability reporting page. Please do not create a public github issue.

Problem:

Our test server and client have some "funky" behavior. We should make them easier to understand and use.

Solution:

  • A user should be able to input how many reconnects they want with the -r flag, rather than s2nc using an arbitrary constant.
  • Is the early_data_recv function printing out an extra new line? Investigate and fix.
  • The echo function is complex and unreadable. We should get rid of the nested while loops if possible 👀
  • The session ticket reconnect behavior in TLS1.2 re-uses the same session ticket 5 of times. We probably want a new session ticket for each reconnect.
  • Does this change what S2N sends over the wire? No
  • Does this change any public APIs? No
  • Which versions of TLS will this impact?
    None

Requirements / Acceptance Criteria:

Fix all the above issues.

  • RFC links: N/A
  • Related Issues: N/A
  • Will the Usage Guide or other documentation need to be updated? No
  • Testing: All current integ tests pass
    • Will this change trigger SAW changes? No
    • Should this change be fuzz tested? No

Out of scope:

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants