Skip to content

Commit 4631ac6

Browse files
committed
refactor(amazonq): addressing code review comments
1 parent 7209d84 commit 4631ac6

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

server/aws-lsp-codewhisperer/src/language-server/securityScan/codeWhispererSecurityScanServer.ts

+5-3
Original file line numberDiff line numberDiff line change
@@ -195,12 +195,14 @@ export const SecurityScanServerToken =
195195
}
196196
logging.log(`Security scan failed. ${error}`)
197197
securityScanTelemetryEntry.result = 'Failed'
198-
const err = getErrorMessage(error)
199-
const exception = hasConnectionExpired(error) ? new AmazonQServiceInvalidConnectionError(err) : error
198+
const errMessage = getErrorMessage(error)
199+
const exception = hasConnectionExpired(error)
200+
? new AmazonQServiceInvalidConnectionError(errMessage)
201+
: error
200202

201203
return {
202204
status: 'Failed',
203-
error: err,
205+
errorMessage: errMessage,
204206
exception: exception,
205207
} as SecurityScanResponse
206208
} finally {

server/aws-lsp-codewhisperer/src/language-server/securityScan/types.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ export interface SecurityScanRequestParams extends ExecuteCommandParams {
6060
export interface SecurityScanResponse {
6161
status: SecurityScanStatus
6262
findings?: SecurityScanFindings
63-
error?: string
63+
errorMessage?: string
6464
exception?: Error
6565
}
6666

server/aws-lsp-codewhisperer/src/shared/amazonQServiceManager/errors.ts

-2
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
11
// Base error class for Amazon Q
22
export class AmazonQError extends Error {
33
public code: string
4-
override message: string
54
constructor(message: string, code: string) {
65
super(message)
76
this.name = 'AmazonQError'
87
this.code = code
9-
this.message = message
108
}
119
}
1210

0 commit comments

Comments
 (0)