Skip to content

Commit 5d7824d

Browse files
rix0rrrRomainMuller
authored andcommitted
feat(pacmak): build all java targets at once (#849)
Improve build speed by building all jsii targets at the same time, and using a special aggregate POM build for Java. - Improves speed by not unnecessarily re-reading jsii assemblies for each individual build. - Improves speed by using an aggregate POM to build all Java targets (can reuse JVM instances and compilation metadata by Maven). - Improves wall-clock time by building all languages in parallel. On my machine, reduces the time to pack the entire CDK repository from 25min user/15min wall clock to 15min user/5 min wall clock.
1 parent 0cc1a4c commit 5d7824d

File tree

28 files changed

+658
-9696
lines changed

28 files changed

+658
-9696
lines changed

packages/jsii-calc-base-of-base/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,7 @@
4848
"python": {
4949
"distName": "scope.jsii-calc-base-of-base",
5050
"module": "scope.jsii_calc_base_of_base"
51-
},
52-
"sphinx": {}
51+
}
5352
},
5453
"versionFormat": "short"
5554
}

packages/jsii-calc-base-of-base/test/assembly.jsii

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,7 @@
3636
"python": {
3737
"distName": "scope.jsii-calc-base-of-base",
3838
"module": "scope.jsii_calc_base_of_base"
39-
},
40-
"sphinx": {}
39+
}
4140
},
4241
"types": {
4342
"@scope/jsii-calc-base-of-base.IVeryBaseInterface": {
@@ -112,5 +111,5 @@
112111
}
113112
},
114113
"version": "0.19.0",
115-
"fingerprint": "7MB5loMgQMPSUAigsYezONp1ouq1gGrVQPD2TZteJlY="
114+
"fingerprint": "Vlx00ifa2hokcWUTvyArHMvCacQmjgyYtwy0zEWGZo0="
116115
}

packages/jsii-calc-base/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,7 @@
5454
"python": {
5555
"distName": "scope.jsii-calc-base",
5656
"module": "scope.jsii_calc_base"
57-
},
58-
"sphinx": {}
57+
}
5958
},
6059
"versionFormat": "short"
6160
}

packages/jsii-calc-base/test/assembly.jsii

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,7 @@
2727
"python": {
2828
"distName": "scope.jsii-calc-base-of-base",
2929
"module": "scope.jsii_calc_base_of_base"
30-
},
31-
"sphinx": {}
30+
}
3231
},
3332
"version": "0.19.0"
3433
}
@@ -53,8 +52,7 @@
5352
"python": {
5453
"distName": "scope.jsii-calc-base-of-base",
5554
"module": "scope.jsii_calc_base_of_base"
56-
},
57-
"sphinx": {}
55+
}
5856
},
5957
"version": "0.19.0"
6058
}
@@ -88,8 +86,7 @@
8886
"python": {
8987
"distName": "scope.jsii-calc-base",
9088
"module": "scope.jsii_calc_base"
91-
},
92-
"sphinx": {}
89+
}
9390
},
9491
"types": {
9592
"@scope/jsii-calc-base.Base": {
@@ -177,5 +174,5 @@
177174
}
178175
},
179176
"version": "0.19.0",
180-
"fingerprint": "UzDw4nRR+4fhd01t0ybeUo6SmdnWdfKbE+pTzl/6voQ="
177+
"fingerprint": "N9LvPVtN5Azr2Ip3FMatwqceL+70AEYPqZk+T7qC/bc="
181178
}

packages/jsii-calc-lib/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,7 @@
5858
"python": {
5959
"distName": "scope.jsii-calc-lib",
6060
"module": "scope.jsii_calc_lib"
61-
},
62-
"sphinx": {}
61+
}
6362
},
6463
"versionFormat": "short"
6564
}

packages/jsii-calc-lib/test/assembly.jsii

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,7 @@
2727
"python": {
2828
"distName": "scope.jsii-calc-base",
2929
"module": "scope.jsii_calc_base"
30-
},
31-
"sphinx": {}
30+
}
3231
},
3332
"version": "0.19.0"
3433
}
@@ -53,8 +52,7 @@
5352
"python": {
5453
"distName": "scope.jsii-calc-base",
5554
"module": "scope.jsii_calc_base"
56-
},
57-
"sphinx": {}
55+
}
5856
},
5957
"version": "0.19.0"
6058
},
@@ -77,8 +75,7 @@
7775
"python": {
7876
"distName": "scope.jsii-calc-base-of-base",
7977
"module": "scope.jsii_calc_base_of_base"
80-
},
81-
"sphinx": {}
78+
}
8279
},
8380
"version": "0.19.0"
8481
}
@@ -118,8 +115,7 @@
118115
"python": {
119116
"distName": "scope.jsii-calc-lib",
120117
"module": "scope.jsii_calc_lib"
121-
},
122-
"sphinx": {}
118+
}
123119
},
124120
"types": {
125121
"@scope/jsii-calc-lib.EnumFromScopedModule": {
@@ -543,5 +539,5 @@
543539
}
544540
},
545541
"version": "0.19.0",
546-
"fingerprint": "fTZVmFlDa7uoeJF41GTcIhD33vnnyxZOgxCeZ1hIvSk="
542+
"fingerprint": "rS2rGvy6Ma6wo/1JfCpR21CQsx8P5YmdtrxJ5EjgXxs="
547543
}

packages/jsii-calc/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,7 @@
6363
"python": {
6464
"distName": "jsii-calc",
6565
"module": "jsii_calc"
66-
},
67-
"sphinx": {}
66+
}
6867
},
6968
"metadata": {
7069
"jsii:boolean": true,

packages/jsii-calc/test/assembly.jsii

Lines changed: 8 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,7 @@
5353
"python": {
5454
"distName": "scope.jsii-calc-base",
5555
"module": "scope.jsii_calc_base"
56-
},
57-
"sphinx": {}
56+
}
5857
},
5958
"version": "0.19.0"
6059
},
@@ -77,8 +76,7 @@
7776
"python": {
7877
"distName": "scope.jsii-calc-base-of-base",
7978
"module": "scope.jsii_calc_base_of_base"
80-
},
81-
"sphinx": {}
79+
}
8280
},
8381
"version": "0.19.0"
8482
},
@@ -103,8 +101,7 @@
103101
"python": {
104102
"distName": "scope.jsii-calc-lib",
105103
"module": "scope.jsii_calc_lib"
106-
},
107-
"sphinx": {}
104+
}
108105
},
109106
"version": "0.19.0"
110107
}
@@ -129,8 +126,7 @@
129126
"python": {
130127
"distName": "scope.jsii-calc-base",
131128
"module": "scope.jsii_calc_base"
132-
},
133-
"sphinx": {}
129+
}
134130
},
135131
"version": "0.19.0"
136132
},
@@ -153,8 +149,7 @@
153149
"python": {
154150
"distName": "scope.jsii-calc-base-of-base",
155151
"module": "scope.jsii_calc_base_of_base"
156-
},
157-
"sphinx": {}
152+
}
158153
},
159154
"version": "0.19.0"
160155
},
@@ -179,8 +174,7 @@
179174
"python": {
180175
"distName": "scope.jsii-calc-lib",
181176
"module": "scope.jsii_calc_lib"
182-
},
183-
"sphinx": {}
177+
}
184178
},
185179
"version": "0.19.0"
186180
}
@@ -228,8 +222,7 @@
228222
"python": {
229223
"distName": "jsii-calc",
230224
"module": "jsii_calc"
231-
},
232-
"sphinx": {}
225+
}
233226
},
234227
"types": {
235228
"jsii-calc.AbstractClass": {
@@ -9617,5 +9610,5 @@
96179610
}
96189611
},
96199612
"version": "0.19.0",
9620-
"fingerprint": "z0M8ATIlYi8ohIQB7KR90oh4pKmIb3EdBoPgS3/lyHM="
9613+
"fingerprint": "nQMF6ipA96E38PvG3NsgKOJIb3ZEit4jNrxZAkgRlbs="
96219614
}

packages/jsii-kernel/test/kernel.test.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,6 @@ defineTest('naming allows returns the module name for different languages', (san
213213
},
214214
js: { npm: 'jsii-calc' },
215215
python: { distName: 'jsii-calc', module: 'jsii_calc' },
216-
sphinx: {},
217216
});
218217
expect(sandbox.naming({ assembly: '@scope/jsii-calc-lib' }).naming).toEqual({
219218
dotnet: {
@@ -227,7 +226,6 @@ defineTest('naming allows returns the module name for different languages', (san
227226
},
228227
js: { npm: '@scope/jsii-calc-lib' },
229228
python: { distName: 'scope.jsii-calc-lib', module: 'scope.jsii_calc_lib' },
230-
sphinx: {},
231229
});
232230
});
233231

0 commit comments

Comments
 (0)