Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(ec2): unreliable test "SSH Agent can start the agent on windows" #6929

Merged
merged 2 commits into from
Apr 7, 2025
Merged

test(ec2): unreliable test "SSH Agent can start the agent on windows" #6929

merged 2 commits into from
Apr 7, 2025

Conversation

justinmk3
Copy link
Contributor

Problem:

SSH Agent
  can start the agent on windows:
  Error: Test length exceeded max duration: 30 seconds
[No Pending UI Elements Found]
  at Timeout._onTimeout (D:\a\aws-toolkit-vscode\aws-toolkit-vscode\packages\core\src\test\setupUtil.ts:46:32)

Solution:

  • retry 2 times.
  • set short timeout.

fix #6891

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@justinmk3 justinmk3 requested a review from a team as a code owner April 3, 2025 19:13
@justinmk3 justinmk3 force-pushed the fixtest branch 2 times, most recently from 62171d4 to 18d2fa6 Compare April 3, 2025 20:18
@justinmk3
Copy link
Contributor Author

👀

  SSH Agent
No Instance(s) Available.

No Instance(s) Available.

No Instance(s) Available.

No Instance(s) Available.

rejected promise not handled within 1 second: Error: Command exited with non-zero code: 1

justinmk3 added 2 commits April 7, 2025 08:50
@justinmk3
test(ec2): unreliable test "SSH Agent can start the agent on windows"
a24de71 
Problem:

    SSH Agent
      can start the agent on windows:
      Error: Test length exceeded max duration: 30 seconds
    [No Pending UI Elements Found]
      at Timeout._onTimeout (D:\a\aws-toolkit-vscode\aws-toolkit-vscode\packages\core\src\test\setupUtil.ts:46:32)

Solution:
- retry 2 times.
@justinmk3
fix(childprocess): log rejected command
5c56251 
Problem:
Unhandled promise rejection results in mysterious CI log message:

    rejected promise not handled within 1 second:
    Error: Command exited with non-zero code: 1

Solution:
Include the command name+args in the rejection message.
@justinmk3 justinmk3 merged commit 191c504 into aws:master Apr 7, 2025
31 checks passed
@justinmk3 justinmk3 deleted the fixtest branch April 7, 2025 16:09
@justinmk3
Copy link
Contributor Author

a96a73e

rejected promise not handled within 1 second: AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
+ actual - expected
+ 'StartPending'
- 'Stopped'
     ^
stack trace: AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
+ actual - expected
+ 'StartPending'
- 'Stopped'
     ^
    at Context.<anonymous> (D:\a\aws-toolkit-vscode\aws-toolkit-vscode\packages\core\src\test\shared\extensions\ssh.test.ts:37:16)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unreliable test: SSH agent - can start the agent on windows
1 participant
@justinmk3