Fix the serverless deploy window breaking when pressing deploy before S3 bucket list loads (#2069)

Fixes #1699

Author: hunterwerlla

jetbrains-core/src/software/aws/toolkits/jetbrains/services/lambda/deploy/DeployServerlessApplicationDialog.kt

@@ -194,6 +194,10 @@ class DeploySamApplicationValidator(private val view: DeployServerlessApplicatio
             return it
         }
 
+        // Is the bucket loading
+        if (view.s3Bucket.isLoading) {
+            return view.s3Bucket.validationInfo(message("serverless.application.deploy.validation.s3.bucket.loading"))
+        }
         // Has the user selected a bucket
         view.s3Bucket.selected() ?: return view.s3Bucket.validationInfo(message("serverless.application.deploy.validation.s3.bucket.empty"))
 

resources/resources/software/aws/toolkits/resources/localized_messages.properties

@@ -680,7 +680,7 @@ serverless.application.deploy.validation.new.stack.name.invalid=A stack name can
 serverless.application.deploy.validation.new.stack.name.missing=Enter the name of your new Stack
 serverless.application.deploy.validation.new.stack.name.too.long=Stack names must not exceed {0} characters in length
 serverless.application.deploy.validation.s3.bucket.empty=Select an S3 Bucket
-serverless.application.deploy.validation.s3.bucket.loading=Still loading S3 bucket...
+serverless.application.deploy.validation.s3.bucket.loading=Still loading the list of S3 buckets...
 serverless.application.deploy.validation.stack.loading=Still loading CloudFormation stacks...
 serverless.application.deploy.validation.stack.missing=Specify a Stack to deploy to
 serverless.application.deploy.validation.template.values.missing=Template values are missing: {0}