Change in Behavior of Client Interrupts Between V1 and V2

[belugabehr]

Describe the bug

In AWS JDK V2, when a client is interrupted, it does not clears the Interrupted Flag. However, there is a comment stating that it does.

aws-sdk-java-v2/core/sdk-core/src/main/java/software/amazon/awssdk/core/io/SdkFilterInputStream.java

Lines 36 to 47 in ffc9ccc

	/**
	* Aborts with subclass specific abortion logic executed if needed.
	* Note the interrupted status of the thread is cleared by this method.
	*
	* @throws AbortedException if found necessary.
	*/
	protected final void abortIfNeeded() {
	if (Thread.currentThread().isInterrupted()) {
	abort(); // execute subclass specific abortion logic
	throw AbortedException.builder().build();
	}
	}

• https://docs.oracle.com/javase/8/docs/api/java/lang/Thread.html#isInterrupted--

In AWS JDK V1, there interrupted status is indeed cleared.

• https://github.com/aws/aws-sdk-java/blob/master/aws-java-sdk-core/src/main/java/com/amazonaws/internal/SdkFilterInputStream.java#L53-L63

• https://github.com/aws/aws-sdk-java/blob/bdca0550fc15769618a51338f5f2f84bc603a1cf/aws-java-sdk-core/src/main/java/com/amazonaws/util/SdkRuntime.java#L20-L26

• https://docs.oracle.com/javase/8/docs/api/java/lang/Thread.html#interrupted--

Please ensure that V2 maintains the same behavior and clear the flag. This will help migrations from V1 to V2.

Regression Issue

• Select this option if this issue appears to be a regression.

Expected Behavior

The Interrupt flag should be cleared.

Current Behavior

The Interrupt flag is not cleared.

Reproduction Steps

Provided code samples in description.

Possible Solution

Provided suggesting in description.

Additional Information/Context

No response

AWS Java SDK version used

2

JDK version used

17

Operating System and version

Linux

[bhoradc]

Hi @belugabehr,

Thanks for reporting the issue. We will look into this to address it soon.

Regards,
Chaitanya

[bhoradc]

Hi @belugabehr,

Modifying the Java SDK V2 behavior to match V1 regarding clearing the interrupt flag could potentially cause compatibility issues for existing V2 users who are already relying on or expecting the current behavior, where the interrupt flag is not cleared.

To avoid breaking existing V2 applications by changing the interrupt flag handling, we have decided to maintain the existing behavior in V2 and update the documentation to accurately reflect it, rather than introducing a change that could disrupt applications that rely on the current behavior.

Thanks again for reporting the discrepancy.

Regards,
Chaitanya

[belugabehr]

Is there a way to set some sort of global compatibility flag (e.g., ENV Variable) to allow existing V1 users the ability to preserve this behavior? This is going to be a subtle change that no one will anticipate moving from V1 to V2.