Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signer Class has since been deprecated but still stated for use in the SdkAdvancedClientOptions #5962

Open
sgaamuwa opened this issue Mar 14, 2025 · 0 comments
Open

Signer Class has since been deprecated but still stated for use in the SdkAdvancedClientOptions #5962

sgaamuwa opened this issue Mar 14, 2025 · 0 comments
Labels
feature-request A feature should be added or improved. p2 This is a standard priority issue

Comments

@sgaamuwa
Copy link

Describe the issue

The SdkAdvancedClientOption class are still using values with type Signer which has been deprecated according to the documentation.

aws-sdk-java-v2/core/sdk-core/src/main/java/software/amazon/awssdk/core/client/config/SdkAdvancedClientOption.java

Line 51 in 8836271

public static final SdkAdvancedClientOption<Signer> SIGNER = new SdkAdvancedClientOption<>(Signer.class);

Documentation states it has been replaced by HttpSigner, but this is not reflected for the advanced options.

Links

https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/core/signer/Signer.html
@sgaamuwa sgaamuwa added documentation This is a problem with documentation. needs-triage This issue or PR still needs to be triaged. labels Mar 14, 2025
@bhoradc bhoradc added needs-review This issue or PR needs review from the team. p2 This is a standard priority issue and removed needs-triage This issue or PR still needs to be triaged. documentation This is a problem with documentation. labels Mar 20, 2025
@bhoradc bhoradc added feature-request A feature should be added or improved. and removed needs-review This issue or PR needs review from the team. labels Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request A feature should be added or improved. p2 This is a standard priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sgaamuwa @bhoradc