fixed code based on mcgrails suggestions

Author: RanVaknin

internal/shareddefaults/shared_config.go

@@ -1,6 +1,7 @@
 package shareddefaults
 
 import (
+	"os/user"
 	"path/filepath"
 )
 
@@ -29,5 +30,17 @@ func SharedConfigFilename() string {
 // UserHomeDir returns the home directory for the user the process is
 // running under.
 func UserHomeDir() string {
-	return userHomeDir()
+	var home string
+
+	home = userHomeDir()
+	if len(home) > 0 {
+		return home
+	}
+
+	currUser, _ := user.Current()
+	if currUser != nil {
+		home = currUser.HomeDir
+	}
+
+	return home
 }

internal/shareddefaults/shared_config_resolve_home_go1.12.go

@@ -5,20 +5,9 @@ package shareddefaults
 
 import (
 	"os"
-	"os/user"
 )
 
 func userHomeDir() string {
 	home, _ := os.UserHomeDir()
-
-	if len(home) > 0 {
-		return home
-	}
-
-	currUser, _ := user.Current()
-	if currUser != nil {
-		home = currUser.HomeDir
-	}
-
 	return home
 }