Skip to content

Commit ac2cb11

Browse files
committed
simplyfy test
1 parent fd2bce6 commit ac2cb11

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

tests/aws-cpp-sdk-s3control-integration-tests/S3ControlTest.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -735,13 +735,13 @@ TEST_F(S3ControlTest, TestRemoveHostPrefix)
735735
ClientConfiguration config;
736736
config.region = Aws::Region::US_EAST_1;
737737
auto s3controlClient = S3ControlClient(config);
738-
Aws::String bucket = "bdaivat-test-ap-bucket--use2-az1--x-s3";
739-
Aws::String accessPointName = "bdaivat-test-ap--use2-az1--xa-s3";
738+
Aws::String bucket = "test-ap-bucket--use2-az1--x-s3";
739+
Aws::String accessPointName = "test-ap--use2-az1--xa-s3";
740740
auto request = CreateAccessPointRequest{}
741741
.WithName(accessPointName)
742742
.WithBucket(bucket)
743-
.WithAccountId("382420381362")
744-
.WithBucketAccountId("382420381362");
743+
.WithAccountId(m_accountId)
744+
.WithBucketAccountId(m_accountId);
745745
auto resolveEndpointOutcome = s3controlClient.accessEndpointProvider()->ResolveEndpoint(request.GetEndpointContextParams());
746746
EXPECT_TRUE(resolveEndpointOutcome.IsSuccess());
747747
EXPECT_EQ(resolveEndpointOutcome.GetResult().GetURL(), "https://s3express-control.us-east-1.amazonaws.com");

tools/code-generation/generator/src/main/resources/com/amazonaws/util/awsclientgenerator/velocity/cpp/common/UriRequestQueryParams.vm

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,7 @@ ${indent} }
2626
#if(!$operation.request.shape.hasEventStreamMembers() && !($serviceNamespace == "S3Crt" && $operation.s3CrtEnabled))
2727
${indent} AWS_OPERATION_CHECK_SUCCESS(endpointResolutionOutcome, ${operation.name}, CoreErrors, CoreErrors::ENDPOINT_RESOLUTION_FAILURE, endpointResolutionOutcome.GetError().GetMessage());
2828
#if($operation.hasEndpointTrait)## Note: EndpointDiscovery Trait is not Endpoint Trait
29-
#if($serviceNamespace == "S3Control" && $serviceModel.rawEndpointRules)
30-
#else
29+
#if(!($serviceNamespace == "S3Control" && $serviceModel.rawEndpointRules))
3130
${indent} auto addPrefixErr = endpointResolutionOutcome.GetResult().AddPrefixIfMissing(${operation.endpoint.constructHostPrefixString("request")});
3231
${indent} AWS_CHECK(SERVICE_NAME, !addPrefixErr, addPrefixErr->GetMessage(), ${operation.name}Outcome(addPrefixErr.value()));
3332
#end

0 commit comments

Comments
 (0)