Skip to content

Commit 9af5cf8

Browse files
authored
Merge branch 'main' into ryanemer/caching-cmm
2 parents cb98f62 + 554ee57 commit 9af5cf8

File tree

2 files changed

+12
-16
lines changed

2 files changed

+12
-16
lines changed

.github/workflows/library_net_tests.yml

+6-13
Original file line numberDiff line numberDiff line change
@@ -73,29 +73,22 @@ jobs:
7373
CORES=$(node -e 'console.log(os.cpus().length)')
7474
make transpile_net CORES=$CORES
7575
76+
# .NET Framework is only supported in Windows
7677
- name: Test ${{ matrix.library }} .NET Framework net48
78+
if: matrix.os == 'windows-latest'
7779
working-directory: ./${{ matrix.library }}
7880
shell: bash
7981
run: |
80-
if [ "$RUNNER_OS" == "macOS" ]; then
81-
DYLD_LIBRARY_PATH="/usr/local/opt/[email protected]/lib"
82-
dotnet run \
83-
--project runtimes/net/tests/ \
84-
--framework net48
85-
else
86-
dotnet run \
87-
--project runtimes/net/tests/ \
88-
--framework net48
89-
fi
82+
make test_net FRAMEWORK=net48
9083
91-
- name: Test ${{ matrix.library }}
84+
- name: Test ${{ matrix.library }} .NET net6.0
9285
working-directory: ./${{ matrix.library }}
9386
shell: bash
9487
run: |
9588
if [ "$RUNNER_OS" == "macOS" ]; then
96-
make test_net_mac_intel
89+
make test_net_mac_intel FRAMEWORK=net6.0
9790
else
98-
make test_net
91+
make test_net FRAMEWORK=net6.0
9992
fi
10093
10194
- name: Test Cache Thread Safety

SharedMakefileV2.mk

+6-3
Original file line numberDiff line numberDiff line change
@@ -307,20 +307,23 @@ transpile_test_net: _transpile_test_all
307307
transpile_dependencies_net: LANG=net
308308
transpile_dependencies_net: transpile_dependencies
309309

310+
test_net_mac_brew: FRAMEWORK=net6.0
310311
test_net:
311312
dotnet run \
312313
--project runtimes/net/tests/ \
313-
--framework net6.0
314+
--framework $(FRAMEWORK)
314315

316+
test_net_mac_brew: FRAMEWORK=net6.0
315317
test_net_mac_intel:
316318
DYLD_LIBRARY_PATH="/usr/local/opt/[email protected]/lib" dotnet run \
317319
--project runtimes/net/tests/ \
318-
--framework net6.0
320+
--framework $(FRAMEWORK)
319321

322+
test_net_mac_brew: FRAMEWORK=net6.0
320323
test_net_mac_brew:
321324
DYLD_LIBRARY_PATH="$(shell brew --prefix)/opt/[email protected]/lib/" dotnet run \
322325
--project runtimes/net/tests/ \
323-
--framework net6.0
326+
--framework $(FRAMEWORK)
324327

325328
setup_net:
326329
dotnet restore runtimes/net/

0 commit comments

Comments
 (0)