Skip to content

Commit b000442

Browse files
author
Joseph Chen
committed
Add vpc-id to leaked eni filters
1 parent eb43e54 commit b000442

File tree

2 files changed

+39
-1
lines changed

2 files changed

+39
-1
lines changed

pkg/awsutils/awsutils.go

+6
Original file line numberDiff line numberDiff line change
@@ -1886,6 +1886,12 @@ func (cache *EC2InstanceMetadataCache) getLeakedENIs() ([]*ec2.NetworkInterface,
18861886
aws.String(ec2.NetworkInterfaceStatusAvailable),
18871887
},
18881888
},
1889+
{
1890+
Name: aws.String("vpc-id"),
1891+
Values: []*string{
1892+
aws.String(cache.vpcID),
1893+
},
1894+
},
18891895
}
18901896
if cache.clusterName != "" {
18911897
leakedENIFilters = append(leakedENIFilters, &ec2.Filter{

pkg/awsutils/awsutils_test.go

+33-1
Original file line numberDiff line numberDiff line change
@@ -1261,6 +1261,10 @@ func TestEC2InstanceMetadataCache_getLeakedENIs(t *testing.T) {
12611261
Name: aws.String("status"),
12621262
Values: []*string{aws.String("available")},
12631263
},
1264+
{
1265+
Name: aws.String("vpc-id"),
1266+
Values: []*string{aws.String(vpcID)},
1267+
},
12641268
},
12651269
MaxResults: aws.Int64(1000),
12661270
},
@@ -1290,6 +1294,10 @@ func TestEC2InstanceMetadataCache_getLeakedENIs(t *testing.T) {
12901294
Name: aws.String("status"),
12911295
Values: []*string{aws.String("available")},
12921296
},
1297+
{
1298+
Name: aws.String("vpc-id"),
1299+
Values: []*string{aws.String(vpcID)},
1300+
},
12931301
},
12941302
MaxResults: aws.Int64(1000),
12951303
},
@@ -1351,6 +1359,10 @@ func TestEC2InstanceMetadataCache_getLeakedENIs(t *testing.T) {
13511359
Name: aws.String("status"),
13521360
Values: []*string{aws.String("available")},
13531361
},
1362+
{
1363+
Name: aws.String("vpc-id"),
1364+
Values: []*string{aws.String(vpcID)},
1365+
},
13541366
},
13551367
MaxResults: aws.Int64(1000),
13561368
},
@@ -1396,6 +1408,10 @@ func TestEC2InstanceMetadataCache_getLeakedENIs(t *testing.T) {
13961408
Name: aws.String("status"),
13971409
Values: []*string{aws.String("available")},
13981410
},
1411+
{
1412+
Name: aws.String("vpc-id"),
1413+
Values: []*string{aws.String(vpcID)},
1414+
},
13991415
},
14001416
MaxResults: aws.Int64(1000),
14011417
},
@@ -1441,6 +1457,10 @@ func TestEC2InstanceMetadataCache_getLeakedENIs(t *testing.T) {
14411457
Name: aws.String("status"),
14421458
Values: []*string{aws.String("available")},
14431459
},
1460+
{
1461+
Name: aws.String("vpc-id"),
1462+
Values: []*string{aws.String(vpcID)},
1463+
},
14441464
},
14451465
MaxResults: aws.Int64(1000),
14461466
},
@@ -1470,6 +1490,10 @@ func TestEC2InstanceMetadataCache_getLeakedENIs(t *testing.T) {
14701490
Name: aws.String("status"),
14711491
Values: []*string{aws.String("available")},
14721492
},
1493+
{
1494+
Name: aws.String("vpc-id"),
1495+
Values: []*string{aws.String(vpcID)},
1496+
},
14731497
{
14741498
Name: aws.String("tag:cluster.k8s.amazonaws.com/name"),
14751499
Values: []*string{aws.String("awesome-cluster")},
@@ -1543,6 +1567,10 @@ func TestEC2InstanceMetadataCache_getLeakedENIs(t *testing.T) {
15431567
Name: aws.String("status"),
15441568
Values: []*string{aws.String("available")},
15451569
},
1570+
{
1571+
Name: aws.String("vpc-id"),
1572+
Values: []*string{aws.String(vpcID)},
1573+
},
15461574
{
15471575
Name: aws.String("tag:cluster.k8s.amazonaws.com/name"),
15481576
Values: []*string{aws.String("awesome-cluster")},
@@ -1596,6 +1624,10 @@ func TestEC2InstanceMetadataCache_getLeakedENIs(t *testing.T) {
15961624
Name: aws.String("status"),
15971625
Values: []*string{aws.String("available")},
15981626
},
1627+
{
1628+
Name: aws.String("vpc-id"),
1629+
Values: []*string{aws.String(vpcID)},
1630+
},
15991631
{
16001632
Name: aws.String("tag:cluster.k8s.amazonaws.com/name"),
16011633
Values: []*string{aws.String("awesome-cluster")},
@@ -1653,7 +1685,7 @@ func TestEC2InstanceMetadataCache_getLeakedENIs(t *testing.T) {
16531685
return nil
16541686
})
16551687
}
1656-
cache := &EC2InstanceMetadataCache{ec2SVC: mockEC2, clusterName: tt.fields.clusterName}
1688+
cache := &EC2InstanceMetadataCache{ec2SVC: mockEC2, clusterName: tt.fields.clusterName, vpcID: vpcID}
16571689
got, err := cache.getLeakedENIs()
16581690
if tt.wantErr != nil {
16591691
assert.EqualError(t, err, tt.wantErr.Error())

0 commit comments

Comments
 (0)