fix(chat): diplay special chars properly and blockquotes formatting #1090
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1090 +/- ##
=======================================
Coverage 13.69% 13.69%
=======================================
Files 2361 2361
Lines 203703 203706 +3
Branches 184067 184070 +3
=======================================
+ Hits 27890 27894 +4
Misses 174425 174425
+ Partials 1388 1387 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GoodluckH
force-pushed
the
1087-bugparent-unable-to-show-regex-in-plain-text-mode
branch
4 times, most recently
from
86d309f to
a7c6147
Compare
crates/q_cli/src/cli/chat/parse.rs
Outdated
| @@ -138,9 +138,6 @@ pub fn interpret_markdown<'a, 'b>( | |||
| match state.in_codeblock { | |||
| false => { | |||
| stateful_alt!( | |||
| // This pattern acts as a short circuit for alphanumeric plaintext | |||
There was a problem hiding this comment.
You have a better idea of what this comment is referring to? Considering it's just being deleted and moved around
There was a problem hiding this comment.
Actually I just moved it back. I think someone else already pushed a fix for displaying square brackets. #971
| @@ -743,7 +742,7 @@ mod tests { | |||
| validate!(bulleted_item_1, "- bullet", [style::Print("• bullet")]); | |||
| validate!(bulleted_item_2, "* bullet", [style::Print("• bullet")]); | |||
| validate!(numbered_item_1, "1. number", [style::Print("1. number")]); | |||
| validate!(blockquote_1, "> hello", [ | |||
There was a problem hiding this comment.
Is this being updated because the model response never has > and instead > directly? I guess if you haven't noticed anything break in your manual testing then it's probably fine
There was a problem hiding this comment.
Yes, it appears that our model is responding back in MKD format. Even in rare case it sends back >, it won't break anything, it'll just show ">" like what it's currently formatted for blockquotes.
There was a problem hiding this comment.
It looks like we have code that handles > specifically, in which case I would prefer we don't remove this test case
There was a problem hiding this comment.
Yes there's a test case for it:
validate!(greater_than_1, ".>.", [style::Print(".>.")]);
68defad to
54e6fb3
Compare
GoodluckH
force-pushed
the
1087-bugparent-unable-to-show-regex-in-plain-text-mode
branch
from
54e6fb3 to
25f2795
Compare
GoodluckH
deleted the
1087-bugparent-unable-to-show-regex-in-plain-text-mode
branch
Issue #, if available:
#1087
Handle Special Chars
Before:
After:
Pretty print blockquotes
Before:
After:
