Skip to content

Commit bc27acb

Browse files
author
David Bell
committed
Use url.Parse instead of strings.Replace
1 parent d9c026b commit bc27acb

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

agent/wsclient/client_test.go

+4-3
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ package wsclient
1515

1616
import (
1717
"io"
18+
"net/url"
1819
"os"
19-
"strings"
2020
"testing"
2121

2222
"github.com/aws/amazon-ecs-agent/agent/acs/model/ecsacs"
@@ -171,9 +171,10 @@ func TestHandleIncorrectURLScheme(t *testing.T) {
171171
mockServer.StartTLS()
172172
defer mockServer.Close()
173173

174-
mockServerURL := strings.Replace(mockServer.URL, "https", "notaparticularlyrealscheme", 1)
174+
mockServerURL, _ := url.Parse(mockServer.URL)
175+
mockServerURL.Scheme = "notaparticularlyrealscheme"
175176

176-
cs := getClientServer(mockServerURL)
177+
cs := getClientServer(mockServerURL.String())
177178
err := cs.Connect()
178179

179180
assert.Error(t, err, "Expected error for incorrect URL scheme")

0 commit comments

Comments
 (0)