prevents a goroutine from being leaked if a timeout occurs when calling forceCloseConnection

hex0punk · sparrc · commit 384129ae2469 · 2021-05-17T12:23:59.000-07:00
diff --git a/agent/wsclient/client.go b/agent/wsclient/client.go
@@ -265,7 +265,7 @@ func (cs *ClientServerImpl) SetReadDeadline(t time.Time) error {
 }
 
 func (cs *ClientServerImpl) forceCloseConnection() {
-	closeChan := make(chan error)
+	closeChan := make(chan error, 1)
 	go func() {
 		closeChan <- cs.Close()
 	}()

Original file line number	Diff line number	Diff line change
`@@ -265,7 +265,7 @@ func (cs *ClientServerImpl) SetReadDeadline(t time.Time) error {`
`265`	`265`	`}`
`266`	`266`
`267`	`267`	`func (cs *ClientServerImpl) forceCloseConnection() {`
`268`		`- closeChan := make(chan error)`
	`268`	`+ closeChan := make(chan error, 1)`
`269`	`269`	`go func() {`
`270`	`270`	`closeChan <- cs.Close()`
`271`	`271`	`}()`