updating trends sql to use account_map #1146
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iakov-aws
reviewed
Mar 25, 2025
| @@ -19,15 +19,10 @@ WITH | |||
| SELECT | |||
| "account_name" | |||
| , "account_id" | |||
| , "parent_account_name" "payer_account_name" | |||
| , "parent_account_id" | |||
There was a problem hiding this comment.
account_map does not have to contain parent_account_id or parent_account_name
There was a problem hiding this comment.
and this query will break in this case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
replaced the reliance on aws_accounts and payer_account_name_map with account_map.
the goal should be just to update the script and not require extra steps to edit the quicksight dataset.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.