Skip to content

feat: powertools examples #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 25, 2022
Merged

feat: powertools examples #97

merged 12 commits into from
Feb 25, 2022

Conversation

sliedig
Copy link
Contributor

@sliedig sliedig commented Feb 21, 2022

Issue #, if available:

Description of changes:

Added examples for:

  • Logging
  • Metrics
  • Tracing

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sliedig sliedig marked this pull request as draft February 21, 2022 05:10
@sliedig sliedig self-assigned this Feb 21, 2022
@sliedig sliedig marked this pull request as ready for review February 24, 2022 16:55
@sliedig sliedig requested a review from amirkaws February 24, 2022 16:55
Copy link
Contributor

@amirkaws amirkaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than runtime in examples/Logging/template.yaml file which I mentioned LGTM

Type: AWS::Serverless::Function # More info about Function Resource: https://github.com/awslabs/serverless-application-model/blob/master/versions/2016-10-31.md#awsserverlessfunction
Properties:
CodeUri: ./src/HelloWorld/
Handler: HelloWorld::HelloWorld.Function::FunctionHandler
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need Runtime: dotnet6 here

@sliedig sliedig merged commit e2382cf into aws-powertools:develop Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants