Skip to content

Commit 7100649

Browse files
authored
fix: Randomize SSM parameter name for Grafana token (#272)
* Randomize SSM parameter name for GF token * Run pre-commit * Add versions
1 parent cc82136 commit 7100649

File tree

5 files changed

+13
-3
lines changed

5 files changed

+13
-3
lines changed

examples/existing-cluster-with-base-and-infra/cleanup.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,4 +28,4 @@ if [[ $? -eq 0 && $destroy_output == *"Destroy complete!"* ]]; then
2828
else
2929
echo "FAILED: Terraform destroy of all targets failed"
3030
exit 1
31-
fi
31+
fi

examples/existing-cluster-with-base-and-infra/install.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,4 +29,4 @@ if [[ ${PIPESTATUS[0]} -eq 0 && $apply_output == *"Apply complete"* ]]; then
2929
else
3030
echo "FAILED: Terraform apply of all modules failed"
3131
exit 1
32-
fi
32+
fi

modules/eks-monitoring/add-ons/external-secrets/README.md

+3
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,15 @@ This deploys an EKS Cluster with the External Secrets Operator. The cluster is p
1111
| <a name="requirement_aws"></a> [aws](#requirement\_aws) | >= 3.72 |
1212
| <a name="requirement_kubectl"></a> [kubectl](#requirement\_kubectl) | >= 2.0.3 |
1313
| <a name="requirement_kubernetes"></a> [kubernetes](#requirement\_kubernetes) | >= 2.10 |
14+
| <a name="requirement_random"></a> [random](#requirement\_random) | >= 3.6.1 |
1415

1516
## Providers
1617

1718
| Name | Version |
1819
|------|---------|
1920
| <a name="provider_aws"></a> [aws](#provider\_aws) | >= 3.72 |
2021
| <a name="provider_kubectl"></a> [kubectl](#provider\_kubectl) | >= 2.0.3 |
22+
| <a name="provider_random"></a> [random](#provider\_random) | >= 3.6.1 |
2123

2224
## Modules
2325

@@ -35,6 +37,7 @@ This deploys an EKS Cluster with the External Secrets Operator. The cluster is p
3537
| [aws_ssm_parameter.secret](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/ssm_parameter) | resource |
3638
| [kubectl_manifest.cluster_secretstore](https://registry.terraform.io/providers/alekc/kubectl/latest/docs/resources/manifest) | resource |
3739
| [kubectl_manifest.secret](https://registry.terraform.io/providers/alekc/kubectl/latest/docs/resources/manifest) | resource |
40+
| [random_uuid.grafana_key_suffix](https://registry.terraform.io/providers/hashicorp/random/latest/docs/resources/uuid) | resource |
3841
| [aws_region.current](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/region) | data source |
3942

4043
## Inputs

modules/eks-monitoring/add-ons/external-secrets/main.tf

+4-1
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,11 @@ YAML
7676
depends_on = [module.external_secrets]
7777
}
7878

79+
resource "random_uuid" "grafana_key_suffix" {
80+
}
81+
7982
resource "aws_ssm_parameter" "secret" {
80-
name = "/terraform-accelerator/grafana-api-key"
83+
name = "/terraform-accelerator/grafana-api-key/${random_uuid.grafana_key_suffix.result}"
8184
description = "SSM Secret to store grafana API Key"
8285
type = "SecureString"
8386
value = jsonencode({

modules/eks-monitoring/add-ons/external-secrets/versions.tf

+4
Original file line numberDiff line numberDiff line change
@@ -14,5 +14,9 @@ terraform {
1414
source = "alekc/kubectl"
1515
version = ">= 2.0.3"
1616
}
17+
random = {
18+
source = "hashicorp/random"
19+
version = ">= 3.6.1"
20+
}
1721
}
1822
}

0 commit comments

Comments
 (0)