Skip to content

fix(all): Add additional consumer proguard rules for missing classes #3000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 11, 2025

Conversation

mattcreaser
Copy link
Member

  • PR title and description conform to Pull Request guidelines.

Issue #, if available: #2998

Description of changes:
Add consumer rules to skip warnings introduced in 2.26.0. The OkHttp4Engine is only referenced safely by Amplify so this is OK, and the Immutable reference is for a static linting annotation and can safely be ignored.

How did you test these changes?
Verified r8 no longer produces warnings for these missing classes.

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser mattcreaser requested a review from a team as a code owner March 10, 2025 13:28
@mattcreaser mattcreaser merged commit b2c2b1f into main Mar 11, 2025
3 checks passed
@mattcreaser mattcreaser deleted the mattcreaser/missing-classes branch March 11, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants