Skip to content

fix(auth): Prevent crash if KeyStore not available (ex: instant app) #2993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 22, 2025

Conversation

tylerjroach
Copy link
Member

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:
#2991

Description of changes:
Prevents uncaught exception that occurs in legacy keystore migration when a keystore isn't available (ex: in an Instant App Launch). Verified that Auth + Authenticator will allow in memory sign in's with these changes.

How did you test these changes?
(Please add a line here how the changes were tested)

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tylerjroach tylerjroach requested a review from a team as a code owner February 21, 2025 19:30
vincetran
vincetran previously approved these changes Feb 21, 2025
@mattcreaser mattcreaser merged commit d3975dc into main Feb 22, 2025
3 checks passed
@mattcreaser mattcreaser deleted the tjroach/prevent-legacy-keystore-crash branch February 22, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants