Skip to content

fix(datastore): Reconcile batch process optimization bug #2727 #2749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 3, 2024

Conversation

joon-won
Copy link
Member

@joon-won joon-won commented Mar 28, 2024

  • [✅] PR title and description conform to Pull Request guidelines.

Issue #, if available:
#2727

Description of changes:

How did you test these changes?
(Please add a line here how the changes were tested)

Documentation update required?

  • [✅] No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • [] Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 43.01%. Comparing base (30a288e) to head (c83cb32).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2749      +/-   ##
==========================================
+ Coverage   43.00%   43.01%   +0.01%     
==========================================
  Files         905      905              
  Lines       29178    29183       +5     
  Branches     4152     4153       +1     
==========================================
+ Hits        12548    12554       +6     
+ Misses      15271    15269       -2     
- Partials     1359     1360       +1     

Copy link
Member

@tylerjroach tylerjroach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good first attempt. This looks like it may be logically correct but there are no tests to assert correct result.

Suggestion for the test: Create a scenario that will remove duplicates as expected. The end result should assert against an expected list.

@joon-won joon-won marked this pull request as ready for review April 4, 2024 19:08
@joon-won joon-won requested a review from a team as a code owner April 4, 2024 19:08
@joon-won joon-won changed the title Reconcile batch process optimization bug #2727 fix(datastore): Reconcile batch process optimization bug #2727 May 2, 2024
@joon-won joon-won merged commit 863330d into main May 3, 2024
3 checks passed
@joon-won joon-won deleted the joonwonc/datastore-batch-reconciliation-bugfix branch May 3, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants