-
Notifications
You must be signed in to change notification settings - Fork 122
fix(datastore): Reconcile batch process optimization bug #2727 #2749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(datastore): Reconcile batch process optimization bug #2727 #2749
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2749 +/- ##
==========================================
+ Coverage 43.00% 43.01% +0.01%
==========================================
Files 905 905
Lines 29178 29183 +5
Branches 4152 4153 +1
==========================================
+ Hits 12548 12554 +6
+ Misses 15271 15269 -2
- Partials 1359 1360 +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good first attempt. This looks like it may be logically correct but there are no tests to assert correct result.
Suggestion for the test: Create a scenario that will remove duplicates as expected. The end result should assert against an expected list.
Issue #, if available:
#2727
Description of changes:
How did you test these changes?
(Please add a line here how the changes were tested)
Documentation update required?
General Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.