fix(auth): fetch device metadata from credential store for remember and forgetDevice
#2601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 3, 2023 11:24
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #2601 +/- ##
=======================================
Coverage 41.71% 41.72%
=======================================
Files 900 900
Lines 28788 28791 +3
Branches 4082 4082
=======================================
+ Hits 12009 12013 +4
- Misses 15459 15461 +2
+ Partials 1320 1317 -3 |
tjleing
changed the title
tjleing
changed the title
remember and forgetDevice
gpanshu
reviewed
Oct 4, 2023
aws-auth-cognito/src/main/java/com/amplifyframework/auth/cognito/RealAWSCognitoAuthPlugin.kt
Show resolved
Hide resolved
gpanshu
reviewed
Oct 4, 2023
aws-auth-cognito/src/main/java/com/amplifyframework/auth/cognito/RealAWSCognitoAuthPlugin.kt
Show resolved
Hide resolved
gpanshu
reviewed
Oct 4, 2023
aws-auth-cognito/src/main/java/com/amplifyframework/auth/cognito/RealAWSCognitoAuthPlugin.kt
Show resolved
Hide resolved
tylerjroach
approved these changes
Oct 10, 2023
gpanshu
approved these changes
Oct 11, 2023
gpanshu
pushed a commit
that referenced
this pull request
Oct 23, 2023
… and `forgetDevice` (#2601) Co-authored-by: Thomas Leing <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2585.
Issue #, if available:
Description of changes:
If Cognito returns
nullnewDeviceMetadatauses our previously-existing metadata if we have it. That goes directly into the AuthN state, so reading it immediately after asignInwill return null.After digging into it for a while, I discovered that Swift does things differently than we currently do -- Swift line vs Android line. This essentially copies Swift's method of doing things. Note that this might mean we could be able to remove
deviceMetadatafromAuthenticationState.SignedInsince I believe we don't actually use it anymore.For review: do we prefer
runBlockingorGlobalScope.launch(orGlobalScope.async)? I'm seeing moreGlobalScope.launchin the code that's already here so I went with that.How did you test these changes?
(Please add a line here how the changes were tested)
Sample app
Documentation update required?
General Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.