fix(auth): Prevent auth calls from processing until configured or errored #2402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpanshu
previously approved these changes
Apr 19, 2023
mattcreaser
previously approved these changes
Apr 19, 2023
mattcreaser
removed this pull request from the merge queue due to the queue being cleared
div5yesh
reviewed
Apr 20, 2023
| @@ -197,6 +197,22 @@ internal class RealAWSCognitoAuthPlugin( | |||
| } | |||
| } | |||
|
|
|||
| internal suspend fun suspendWhileConfiguring() { | |||
| return suspendCoroutine { continuation -> | |||
There was a problem hiding this comment.
Do we still need the latch in initialize() above?
There was a problem hiding this comment.
Yes, I wanted to keep that to still throw on an auth plugin configuration error. These checks have different purposes.
mattcreaser
approved these changes
Apr 20, 2023
gpanshu
approved these changes
Apr 20, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#2341
Description of changes:
How did you test these changes?
(Please add a line here how the changes were tested)
Documentation update required?
General Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.