Skip to content

Commit 937cf5a

Browse files
committed
Addressed PR feedback
1 parent f09dead commit 937cf5a

File tree

1 file changed

+7
-12
lines changed

1 file changed

+7
-12
lines changed

aws-auth-cognito/src/main/java/com/amplifyframework/auth/cognito/RealAWSCognitoAuthPlugin.kt

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -138,16 +138,16 @@ import com.amplifyframework.statemachine.codegen.states.SRPSignInState
138138
import com.amplifyframework.statemachine.codegen.states.SignInChallengeState
139139
import com.amplifyframework.statemachine.codegen.states.SignInState
140140
import com.amplifyframework.statemachine.codegen.states.SignOutState
141+
import kotlinx.coroutines.DelicateCoroutinesApi
142+
import kotlinx.coroutines.GlobalScope
143+
import kotlinx.coroutines.async
144+
import kotlinx.coroutines.launch
141145
import java.util.concurrent.CountDownLatch
142146
import java.util.concurrent.TimeUnit
143147
import java.util.concurrent.atomic.AtomicReference
144148
import kotlin.coroutines.resume
145149
import kotlin.coroutines.resumeWithException
146150
import kotlin.coroutines.suspendCoroutine
147-
import kotlinx.coroutines.DelicateCoroutinesApi
148-
import kotlinx.coroutines.GlobalScope
149-
import kotlinx.coroutines.async
150-
import kotlinx.coroutines.launch
151151

152152
internal class RealAWSCognitoAuthPlugin(
153153
private val configuration: AuthConfiguration,
@@ -464,17 +464,16 @@ internal class RealAWSCognitoAuthPlugin(
464464
onError: Consumer<AuthException>
465465
) {
466466
authStateMachine.getCurrentState { authState ->
467+
val signInOptions = options as? AWSCognitoAuthSignInOptions ?: AWSCognitoAuthSignInOptions.builder()
468+
.authFlowType(configuration.authFlowType)
469+
.build()
467470
when (authState.authNState) {
468471
is AuthenticationState.NotConfigured -> onError.accept(
469472
InvalidUserPoolConfigurationException()
470473
)
471474
// Continue sign in
472475
is AuthenticationState.SignedOut,
473476
is AuthenticationState.Configured -> {
474-
val signInOptions = options as? AWSCognitoAuthSignInOptions ?: AWSCognitoAuthSignInOptions.builder()
475-
.authFlowType(configuration.authFlowType)
476-
.build()
477-
478477
_signIn(username, password, signInOptions, onSuccess, onError)
479478
}
480479
is AuthenticationState.SignedIn -> onError.accept(SignedInException())
@@ -486,10 +485,6 @@ internal class RealAWSCognitoAuthPlugin(
486485
when (authState.authNState) {
487486
is AuthenticationState.SignedOut -> {
488487
authStateMachine.cancel(token)
489-
val signInOptions = options as?
490-
AWSCognitoAuthSignInOptions ?: AWSCognitoAuthSignInOptions.builder()
491-
.authFlowType(configuration.authFlowType)
492-
.build()
493488
_signIn(username, password, signInOptions, onSuccess, onError)
494489
}
495490
else -> Unit

0 commit comments

Comments
 (0)