Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: separate environmentVariables and secrets condition checks to avoid unintended nesting #368

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

jnyo
Copy link

@jnyo jnyo commented Feb 8, 2025

Issue #, if available:
Fix #347, and similar comment #334 (comment)

This pull request separates the condition checks for environmentVariables and secrets.

Previously, the secrets check was nested inside the environmentVariables condition, which could lead to unintended dependencies or confusion in the logic.

Description of changes:

  • Moved the secrets condition check outside of the environmentVariables block.
  • Ensured both conditions are evaluated independently.

Note
Previous Pull Request #334 that introduced secrets, there was a mention of "backward compatibility".

There is already a pull request here #143 which tries to do this, but it isn't backward compatible

Does this refer to secrets being nested under environmentVariables?
If so, this change modifies that behavior and needs further consideration.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jnyo jnyo changed the title fix: separate envFiles and secrets condition checks to avoid unintended nesting fix: separate environmentVariables and secrets condition checks to avoid unintended nesting Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Secrets Not Set Unless 'environment-variables' Are Specified
3 participants