-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Test ES modules don't seem to work without esm
package
#2262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Sorry. Somehow submitted prematurely. Editing. |
esm
packageesm
package
Done editing description. |
AVA only transpiles your test files though. This error is coming from a source file. The good news, as it were, is that we're looking to remove the out-of-the-box transpilation. So at least things will be less confusing. (I'm closing this issue for housekeeping purposes, but let's keep the conversation going.) |
Thank you for the information, @novemberborn. So it seems that I'm doing the right thing using the |
Uh oh!
There was an error while loading. Please reload this page.
Thank you for my favorite test runner.
The ES modules recipe says:
The Babel recipe also says:
And it also says:
But my tests, which are written in TypeScript and ES modules and are not transpiled to CommonJS, but remain ES modules, are failing AVA. Here is a copy paste from my terminal:
Here is the pull request where I am trying to remove usage of the
esm
package:https://github.com/cycle-components/pick-path-router/pull/93
Here are the changes.
And here is the failure in the CI log.
The text was updated successfully, but these errors were encountered: