Skip to content

Multi-resource schema Patch: Connection, Client and Resource Server #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 22, 2025

Conversation

duedares-rvj
Copy link
Member

@duedares-rvj duedares-rvj commented May 21, 2025

🔧 Changes

  1. Added new field flexible_mappings to auth0_client which works as a placeholder for complex maps where keys are slices. Required marshal/unmarshal logic has been added to go-auth0
  2. The custom_headers field has been updated to a set of objects. Each object being a map with header/value as keys. This allows proper validation of fields on terraform, while maintaining the order of items and avoiding noisy plans.
  3. Default value for the description field has been introduced for auth0_resource_server_scopes

📚 References

Closes #1243
Closes #1138
Closes #1256

🔬 Testing

Relevant test cases have been updated and re-recorded.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@duedares-rvj duedares-rvj requested a review from a team as a code owner May 21, 2025 10:38
@duedares-rvj duedares-rvj changed the title Handle customHeaders and mappings field for client and connection Multi-resource schema Patch: Connection, Client and Resource Server May 22, 2025
@duedares-rvj duedares-rvj self-assigned this May 22, 2025
Copy link
Contributor

@developerkunal developerkunal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@duedares-rvj duedares-rvj merged commit 0502926 into main May 22, 2025
7 checks passed
@duedares-rvj duedares-rvj deleted the DXCDT-1022/MinorPatchesv1 branch May 22, 2025 17:10
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.54%. Comparing base (66f3810) to head (c13a145).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1253      +/-   ##
==========================================
+ Coverage   88.52%   88.54%   +0.01%     
==========================================
  Files         141      141              
  Lines       19536    19567      +31     
==========================================
+ Hits        17295    17326      +31     
  Misses       1615     1615              
  Partials      626      626              
Files with missing lines Coverage Δ
internal/auth0/client/expand.go 94.31% <100.00%> (+<0.01%) ⬆️
internal/auth0/client/flatten.go 93.96% <100.00%> (+0.04%) ⬆️
internal/auth0/client/resource.go 97.04% <100.00%> (+0.02%) ⬆️
internal/auth0/connection/expand.go 93.47% <100.00%> (+<0.01%) ⬆️
internal/auth0/connection/flatten.go 80.50% <100.00%> (+0.24%) ⬆️
internal/auth0/resourceserver/resource_scopes.go 84.34% <100.00%> (+0.13%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants