Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

HTML not rendered #56

Closed
prydie opened this issue Apr 3, 2014 · 4 comments · Fixed by #73
Closed

HTML not rendered #56

prydie opened this issue Apr 3, 2014 · 4 comments · Fixed by #73
Assignees
@kevinsawicki
Labels
bug

Comments

@prydie
Copy link

prydie commented Apr 3, 2014

As far as I can work out the preview does not render HTML

Examples of non-rendered HTML include:

<sup>1</sup>

<a name="anchor"></a>

I haven't done any testing to check if any other HTML is rendered.
@izuzak
Copy link
Contributor

izuzak commented Apr 5, 2014

This is happening because marked is being called with sanitize: true. With that option set to true, marked will skip all HTML in the input.

It'd be great if marked could sanitize only some HTML tags (e.g. <script>), but it seems that's not possible currently.

@prydie
Copy link
Author

prydie commented Apr 5, 2014

I suggest that it is more appropriate to call marked with sanitize: false for our usage scenario as sanitisation is only appropriate in a context where the author is untrusted and when using their editor an author is presumably trusted.

@prydie
Copy link
Author

prydie commented Apr 5, 2014

See PR: #59

@izuzak izuzak mentioned this issue Apr 26, 2014
Closed
@kevinsawicki kevinsawicki mentioned this issue May 2, 2014
Merged
@kevinsawicki kevinsawicki self-assigned this May 2, 2014
@kevinsawicki
Copy link
Contributor

This will be fixed in the next Atom release, 0.93.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kevinsawicki kevinsawicki

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sanitize using cheerio instead of marked atom/markdown-preview
3 participants
@izuzak @prydie @kevinsawicki