Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrupted diff when a file path includes unusual characters #111

Open
marcellourbani opened this issue Feb 13, 2025 · 1 comment
Open

Corrupted diff when a file path includes unusual characters #111

marcellourbani opened this issue Feb 13, 2025 · 1 comment

Comments

@marcellourbani
Copy link

Describe the bug
My files have names like src/#bti#te_cl_check_authorisation.clas.abap. The extension doesn’t handle them properly, which leads to bogus results.

To Reproduce
Steps to reproduce the behavior:

Create a pull request in a project with files who start by #foo#
click on the fiff

Expected behavior
want to see the diff

Screenshots

This looks like this in Bitbucket cloud:

Image

and like this in vscode:

Image

Environment and Version (please complete the following information):

  • Atlassian Plugin Version (3.5.15)
  • Visual Studio Code Version (1.97.0)
  • Is this a local or cloud environment? (Local)
  • If Local, OS ( linux)

Additional context

Was https://bitbucket.org/atlassianlabs/atlascode/issues/5434
marcellourbani added a commit to marcellourbani/atlascode that referenced this issue Feb 13, 2025
@marcellourbani
Corrupted diff when a file path includes unusual characters
a5769a4 
Fixes atlassian#111
@marcellourbani marcellourbani mentioned this issue Feb 14, 2025
Closed
@marcomura marcomura mentioned this issue Apr 11, 2025
Open
2 tasks
@marcomura
Copy link
Contributor

Hello @marcellourbani ,

I'm struggling to get a repo for this issue with atlascode v3.4.25.

I tried creating a file with a unicode in it, or with a '#' in it, but the diff for both look good:

Bitbucket:
Image

Atlascode:
Image
Image

What am I missing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes 111 Corrupted diff when a file path includes unusual characters marcellourbani/atlascode
2 participants
@marcellourbani @marcomura