Skip to content

Commit 252c6b5

Browse files
thinkerourghetia
authored andcommitted
add interface implement check (open-telemetry#35)
1 parent c0a5fd1 commit 252c6b5

File tree

2 files changed

+32
-17
lines changed

2 files changed

+32
-17
lines changed

api/tag/map.go

+4-4
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,15 @@ import (
2121
"github.com/open-telemetry/opentelemetry-go/api/core"
2222
)
2323

24-
type tagMap map[core.Key]tagContent
25-
2624
type tagContent struct {
2725
value core.Value
2826
meta core.MeasureMetadata
2927
}
3028

29+
type tagMap map[core.Key]tagContent
30+
31+
var _ Map = (*tagMap)(nil)
32+
3133
func (t tagMap) Apply(a1 core.KeyValue, attributes []core.KeyValue, m1 core.Mutator, mutators []core.Mutator) Map {
3234
m := make(tagMap, len(t)+len(attributes)+len(mutators))
3335
for k, v := range t {
@@ -80,8 +82,6 @@ func (m tagMap) Foreach(f func(kv core.KeyValue) bool) {
8082
}
8183
}
8284

83-
var _ Map = (*tagMap)(nil)
84-
8585
func (m tagMap) apply(mutator core.Mutator) {
8686
if m == nil {
8787
return

api/tag/tag.go

+28-13
Original file line numberDiff line numberDiff line change
@@ -23,22 +23,20 @@ import (
2323
"github.com/open-telemetry/opentelemetry-go/exporter/observer"
2424
)
2525

26+
type ctxTagsType struct{}
27+
28+
var (
29+
ctxTagsKey = &ctxTagsType{}
30+
)
31+
2632
type registeredKey struct {
2733
name string
2834
desc string
2935
unit unit.Unit
3036
eventID core.EventID
3137
}
3238

33-
type ctxTagsType struct{}
34-
35-
type measure struct {
36-
rk *registeredKey
37-
}
38-
39-
var (
40-
ctxTagsKey = &ctxTagsType{}
41-
)
39+
var _ core.Key = (*registeredKey)(nil)
4240

4341
func register(name string, opts []Option) *registeredKey {
4442
rk := &registeredKey{
@@ -195,6 +193,12 @@ func (k *registeredKey) Value(ctx context.Context) core.KeyValue {
195193
}
196194
}
197195

196+
type measure struct {
197+
rk *registeredKey
198+
}
199+
200+
var _ core.Mearsure = (*measure)(nil)
201+
198202
func (m measure) M(v float64) core.Measurement {
199203
return core.Measurement{
200204
Measure: m,
@@ -206,7 +210,18 @@ func (m measure) V(v float64) core.KeyValue {
206210
return m.rk.Float64(v)
207211
}
208212

209-
func (m measure) Name() string { return m.rk.Name() }
210-
func (m measure) Description() string { return m.rk.Description() }
211-
func (m measure) Unit() unit.Unit { return m.rk.Unit() }
212-
func (m measure) DefinitionID() core.EventID { return m.rk.DefinitionID() }
213+
func (m measure) Name() string {
214+
return m.rk.Name()
215+
}
216+
217+
func (m measure) Description() string {
218+
return m.rk.Description()
219+
}
220+
221+
func (m measure) Unit() unit.Unit {
222+
return m.rk.Unit()
223+
}
224+
225+
func (m measure) DefinitionID() core.EventID {
226+
return m.rk.DefinitionID()
227+
}

0 commit comments

Comments
 (0)