fix: dynamic topic params out of order and non-bean methods added to application.yml #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uded in the generated application.yml file; order of variables in topic are fixed
CameronRushton
requested review from
damaru-inc and
asyncapi-bot-eve
as code owners
|
Kudos, SonarCloud Quality Gate passed!
|
MichaelDavisSolace
approved these changes
Aug 25, 2022
damaru-inc
approved these changes
Aug 25, 2022
|
🎉 This PR is included in version 0.13.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dynamic bindings had two issues.
A topic that was my/topic/{var1}/{var2} may generate code building the string like String.format("my/topic/%s/%s", var2, var1); which has the variables out of order.
The logic for constructing these variable params has been refactored and sorted based on the position the variable is found in the topic. This means the variables can be listed in any order in the asyncAPI document and the code will always generate the correct order. Caveat: We can't have the same variable twice in the topic.
The dynamic binding that was a supplier of type streamBridge, doesn't get created as a bean. It was expected for this function to not be added to application.yml, so now the dynamic bindings that fit that description to not be beans are no longer added to application.yml.
Additionally, I've given the test folders names based on the test name to make testing easier.
Fixes #240