fix: generated code missing import statements when using template extension #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CameronRushton
commented
Feb 24, 2022
|
|
||
| exports[`template integration tests using the generator should return payload when using x-scs-function-name instead of logging the message 1`] = ` | ||
| " | ||
| import java.util.function.Supplier; |
There was a problem hiding this comment.
This is why this is no good. Should be Consumer.
CameronRushton
commented
Feb 24, 2022
| @@ -0,0 +1,38 @@ | |||
| components: | |||
There was a problem hiding this comment.
We already had a file like this for dynamic topics so I made another one here for static ones that ensure uses Function instead of Consumer.
|
Kudos, SonarCloud Quality Gate passed!
|
damaru-inc
approved these changes
Feb 24, 2022
|
🎉 This PR is included in version 0.11.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When generating code using a dynamic topic and both the function names are the same using x-scs-function-name, the function in Application.java returns a Consumer whose java import is missing (java.util.function.Consumer).
Solution
When spec.functionAsConsumer is true, import Consumer. Previously, this said to import Supplier (bug).
Notes
I've also cleaned up the tests; they're separated into different commits, so you can see the fix in the first commit and the cleanup in the next commit.
Related issue(s)
Resolves #225