Skip to content

Rename spatial objects from *Search to *Region #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 of 7 tasks
hombit opened this issue May 1, 2025 · 0 comments
Open
1 of 7 tasks

Rename spatial objects from *Search to *Region #736

hombit opened this issue May 1, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@hombit
Copy link
Contributor

hombit commented May 1, 2025

Feature request

"Region selection" terminology looks more intuitive for astronomers than "search filtering". I propose to change:

  • *Search -> *Region or use astropy regions library classes instead
  • Catalog.read_hats(search_filter=) -> read_hats(region=)
  • Catalog.*_search -> Catalog.*_region
  • Catalog.search -> Catalog.select_region

Related to #664

Before submitting
Please check the following:

  • I have described the purpose of the suggested change, specifying what I need the enhancement to accomplish, i.e. what problem it solves.
  • I have included any relevant links, screenshots, environment information, and data relevant to implementing the requested feature, as well as pseudocode for how I want to access the new functionality.
  • If I have ideas for how the new feature could be implemented, I have provided explanations and/or pseudocode and/or task lists for the steps.
@hombit hombit added the enhancement New feature or request label May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

1 participant