Skip to content

Google Operators don't support all authentication parameters #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
m1racoli opened this issue Sep 19, 2022 · 2 comments · Fixed by #703
Closed

Google Operators don't support all authentication parameters #651

m1racoli opened this issue Sep 19, 2022 · 2 comments · Fixed by #703
Assignees
Labels
bug Something isn't working

Comments

@m1racoli
Copy link

m1racoli commented Sep 19, 2022

Describe the bug

The following implementation of Google operators ignore authentication parameters delegate_to and impersonation_chain. These parameters are supported by their sync counterparts as it is documented (where applicable).

It is important that those parameters are respected when loading the hook during the synchronous execute call as well as in the corresponding defer call to the trigger (and thus in the trigger as well).

To Reproduce

Using impersonation_chain with BigQueryInsertJobOperatorAsync will result in the task using the identity provided by the credentials of the GCP connection.

Expected behaviour

It should use the identity as defined in impersonation_chain.

@m1racoli m1racoli added the bug Something isn't working label Sep 19, 2022
@m1racoli m1racoli changed the title Google Operators and Sensor don't support all authentication parameters Google Operators don't support all authentication parameters Sep 19, 2022
@phanikumv
Copy link
Collaborator

Thank you @m1racoli for creating the issue!

@m1racoli
Copy link
Author

Thanks! I am not sure I managed to discover all cases. My findings are based on the search for :param impersonation_chain: in the doc string. The BigQuery and GCS sensors as well as the GKEStartPodOperatorAsync seem to support these parameters already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
4 participants