Review feedback

Author: zanieb

crates/cache-key/src/canonical_url.rs

@@ -107,13 +107,14 @@ impl RepositoryUrl {
     pub fn new(url: &Url) -> RepositoryUrl {
         let mut url = CanonicalUrl::new(url).0;
 
-        // Clone to avoid borrow checker issues
-        let immutable_url = url.clone();
-
         // If a Git URL ends in a reference (like a branch, tag, or commit), remove it.
         if url.scheme().starts_with("git+") {
-            if let Some((prefix, _)) = immutable_url.path().rsplit_once('@') {
-                url.set_path(prefix);
+            if let Some(prefix) = url
+                .path()
+                .rsplit_once('@')
+                .map(|(prefix, _suffix)| prefix.to_string())
+            {
+                url.set_path(&prefix);
             }
         }
 

crates/uv-git/src/lib.rs

@@ -62,15 +62,16 @@ impl TryFrom<Url> for GitUrl {
         url.set_fragment(None);
         url.set_query(None);
 
-        // Clone to avoid borrow checker issues
-        let immutable_url = url.clone();
-
         // If the URL ends with a reference, like `https://git.example.com/[email protected]`,
         // extract it.
         let mut reference = GitReference::DefaultBranch;
-        if let Some((prefix, rev)) = immutable_url.path().rsplit_once('@') {
-            reference = GitReference::from_rev(rev);
-            url.set_path(prefix);
+        if let Some((prefix, suffix)) = url
+            .path()
+            .rsplit_once('@')
+            .map(|(prefix, suffix)| (prefix.to_string(), suffix.to_string()))
+        {
+            reference = GitReference::from_rev(&suffix);
+            url.set_path(&prefix);
         }
 
         let precise = if let GitReference::FullCommit(rev) = &reference {