Skip to content

Commit 8f45834

Browse files
committed
Sort extras and groups when comparing lockfile requirements
1 parent a7166ff commit 8f45834

File tree

1 file changed

+10
-5
lines changed
  • crates/uv-resolver/src/lock

1 file changed

+10
-5
lines changed

crates/uv-resolver/src/lock/mod.rs

+10-5
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ use petgraph::visit::EdgeRef;
1515
use rustc_hash::{FxHashMap, FxHashSet};
1616
use serde::Serializer;
1717
use toml_edit::{value, Array, ArrayOfTables, InlineTable, Item, Table, Value};
18-
use tracing::trace;
18+
use tracing::{debug, trace};
1919
use url::Url;
2020

2121
use uv_cache_key::RepositoryUrl;
@@ -1310,15 +1310,15 @@ impl Lock {
13101310
let satisfied = metadata.is_some_and(|metadata| {
13111311
match satisfies_requires_dist(metadata, package, root) {
13121312
Ok(SatisfiesResult::Satisfied) => {
1313-
trace!("Static `Requires-Dist` for `{}` is up-to-date", package.id);
1313+
debug!("Static `Requires-Dist` for `{}` is up-to-date", package.id);
13141314
true
13151315
},
13161316
Ok(..) => {
1317-
trace!("Static `Requires-Dist` for `{}` is out-of-date; falling back to distribution database", package.id);
1317+
debug!("Static `Requires-Dist` for `{}` is out-of-date; falling back to distribution database", package.id);
13181318
false
13191319
},
13201320
Err(..) => {
1321-
trace!("Static `Requires-Dist` for `{}` is invalid; falling back to distribution database", package.id);
1321+
debug!("Static `Requires-Dist` for `{}` is invalid; falling back to distribution database", package.id);
13221322
false
13231323
},
13241324
}
@@ -4131,7 +4131,12 @@ fn normalize_url(mut url: Url) -> UrlString {
41314131
/// 2. Ensures that the lock and install paths are appropriately framed with respect to the
41324132
/// current [`Workspace`].
41334133
/// 3. Removes the `origin` field, which is only used in `requirements.txt`.
4134-
fn normalize_requirement(requirement: Requirement, root: &Path) -> Result<Requirement, LockError> {
4134+
fn normalize_requirement(mut requirement: Requirement, root: &Path) -> Result<Requirement, LockError> {
4135+
// Sort the extras and groups for consistency.
4136+
requirement.extras.sort();
4137+
requirement.groups.sort();
4138+
4139+
// Normalize the requirement source.
41354140
match requirement.source {
41364141
RequirementSource::Git {
41374142
mut repository,

0 commit comments

Comments
 (0)