remove hex encoding of git object IDs

Author: ibraheemdev

Cargo.lock

@@ -19,7 +19,6 @@ uv-fs = { workspace = true }
 anyhow = { workspace = true }
 thiserror = { workspace = true }
 cargo-util = { workspace = true }
-hex = { workspace = true }
 reqwest = { workspace = true, features = ["blocking"] }
 tokio = { workspace = true }
 tracing = { workspace = true }

crates/uv-git/Cargo.toml

@@ -185,7 +185,9 @@ impl GitRepository {
             .cwd(&self.path)
             .exec_with_streaming(&mut silent, &mut silent, true)?;
 
-        Ok(GitOid::from_hex(&result.stdout)?)
+        let mut result = String::from_utf8(result.stdout)?;
+        result.truncate(result.trim_end().len());
+        Ok(result.parse()?)
     }
 }
 

crates/uv-git/src/git.rs

@@ -44,40 +44,18 @@ impl FromStr for GitSha {
 #[derive(Debug, Copy, Clone, PartialEq, Eq, PartialOrd, Ord, Hash)]
 pub struct GitOid {
     len: usize,
-    bytes: [u8; 20],
+    bytes: [u8; 40],
 }
 
 impl GitOid {
     /// Return the string representation of an object ID.
     pub(crate) fn as_str(&self) -> &str {
         str::from_utf8(&self.bytes[..self.len]).unwrap()
     }
-
-    /// Parse an object ID from a hex string.
-    pub(crate) fn from_hex(s: &[u8]) -> Result<Self, OidParseError> {
-        if s.is_empty() {
-            return Err(OidParseError::Empty);
-        }
-
-        if s.len() > 40 {
-            return Err(OidParseError::TooLong);
-        }
-
-        // TODO: support odd length strings
-        let mut out = [0; 20];
-        hex::decode_to_slice(s, &mut out[..s.len() / 2])?;
-
-        Ok(GitOid {
-            len: s.len(),
-            bytes: out,
-        })
-    }
 }
 
 #[derive(Debug, Error, PartialEq)]
 pub enum OidParseError {
-    #[error("Failed to parse hex object ID: `{0}`")]
-    HexError(#[from] hex::FromHexError),
     #[error("Object ID can be at most 40 hex characters")]
     TooLong,
     #[error("Object ID cannot be parsed from empty string")]
@@ -88,7 +66,21 @@ impl FromStr for GitOid {
     type Err = OidParseError;
 
     fn from_str(s: &str) -> Result<Self, Self::Err> {
-        GitOid::from_hex(s.as_bytes())
+        if s.is_empty() {
+            return Err(OidParseError::Empty);
+        }
+
+        if s.len() > 40 {
+            return Err(OidParseError::TooLong);
+        }
+
+        let mut out = [0; 40];
+        out[..s.len()].copy_from_slice(s.as_bytes());
+
+        Ok(GitOid {
+            len: s.len(),
+            bytes: out,
+        })
     }
 }