Add and sync files to the database

Author: dhruvmanila

crates/red_knot_server/src/server/api/notifications/did_close.rs

@@ -2,12 +2,15 @@ use lsp_server::ErrorCode;
 use lsp_types::notification::DidCloseTextDocument;
 use lsp_types::DidCloseTextDocumentParams;
 
+use ruff_db::files::File;
+
 use crate::server::api::diagnostics::clear_diagnostics;
 use crate::server::api::traits::{NotificationHandler, SyncNotificationHandler};
 use crate::server::api::LSPResult;
 use crate::server::client::{Notifier, Requester};
 use crate::server::Result;
 use crate::session::Session;
+use crate::system::url_to_system_path;
 
 pub(crate) struct DidCloseTextDocumentHandler;
 
@@ -22,12 +25,18 @@ impl SyncNotificationHandler for DidCloseTextDocumentHandler {
         _requester: &mut Requester,
         params: DidCloseTextDocumentParams,
     ) -> Result<()> {
+        let Ok(path) = url_to_system_path(&params.text_document.uri) else {
+            return Ok(());
+        };
+
         let key = session.key_from_url(params.text_document.uri);
         session
             .close_document(&key)
             .with_failure_code(ErrorCode::InternalError)?;
 
-        // TODO(dhruvmanila): Close the file in the `RootDatabase`
+        if let Some(db) = session.workspace_db_for_path_mut(path.as_std_path()) {
+            File::sync_path(db.get_mut(), &path);
+        }
 
         clear_diagnostics(key.url(), &notifier)?;
 

crates/red_knot_server/src/server/api/notifications/did_open.rs

@@ -1,10 +1,12 @@
 use lsp_types::notification::DidOpenTextDocument;
 use lsp_types::DidOpenTextDocumentParams;
+use ruff_db::files::{system_path_to_file, File};
 
 use crate::server::api::traits::{NotificationHandler, SyncNotificationHandler};
 use crate::server::client::{Notifier, Requester};
 use crate::server::Result;
 use crate::session::Session;
+use crate::system::url_to_system_path;
 use crate::TextDocument;
 
 pub(crate) struct DidOpenTextDocumentHandler;
@@ -20,10 +22,18 @@ impl SyncNotificationHandler for DidOpenTextDocumentHandler {
         _requester: &mut Requester,
         params: DidOpenTextDocumentParams,
     ) -> Result<()> {
+        let Ok(path) = url_to_system_path(&params.text_document.uri) else {
+            return Ok(());
+        };
+
         let document = TextDocument::new(params.text_document.text, params.text_document.version);
         session.open_text_document(params.text_document.uri, document);
 
-        // TODO(dhruvmanila): Open the file in the `RootDatabase`
+        if let Some(db) = session.workspace_db_for_path_mut(path.as_std_path()) {
+            // TODO(dhruvmanila): Store the `file` in `TextDocument`
+            let _file = system_path_to_file(&**db, &path).unwrap();
+            File::sync_path(db.get_mut(), &path);
+        }
 
         // Publish diagnostics if the client doesn't support pull diagnostics
 

crates/red_knot_server/src/session.rs

@@ -95,6 +95,16 @@ impl Session {
             .map(|(_, db)| db)
     }
 
+    pub(crate) fn workspace_db_for_path_mut(
+        &mut self,
+        path: impl AsRef<Path>,
+    ) -> Option<&mut salsa::Handle<RootDatabase>> {
+        self.workspaces
+            .range_mut(..=path.as_ref().to_path_buf())
+            .next_back()
+            .map(|(_, db)| db)
+    }
+
     pub fn key_from_url(&self, url: Url) -> DocumentKey {
         self.index().key_from_url(url)
     }

crates/red_knot_server/src/session/index.rs

@@ -250,7 +250,7 @@ impl DocumentController {
 /// A read-only query to an open document.
 /// This query can 'select' a text document, full notebook, or a specific notebook cell.
 /// It also includes document settings.
-#[derive(Clone)]
+#[derive(Debug, Clone)]
 pub enum DocumentQuery {
     Text {
         file_url: Url,